From: Daniel Mack <zonque@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Add package connman
Date: Mon, 05 Dec 2011 20:32:34 +0100 [thread overview]
Message-ID: <4EDD1C52.1050907@gmail.com> (raw)
In-Reply-To: <20111205202028.75432ef3@skate>
Hi Thomas,
On 12/05/2011 08:20 PM, Thomas Petazzoni wrote:
> Le Mon, 05 Dec 2011 18:26:10 +0100,
> Daniel Mack <zonque@gmail.com> a ?crit :
>
>> I'm cloning from a git repository, for the reason described in the
>> commit log. Hence, the configure script has to be generated.
>
> Could you add a comment above the _AUTORECONF=YES line mentioning this
> reason ?
Really? The commit log already states the fact and the reason for the
git checkout, and AFAIK, all packages that are pulled from upstream
repositories have to have _AUTORECONF=YES, don't they?
I can do that, I'm just wondering if that one comment line is worth
another version :)
Daniel
next prev parent reply other threads:[~2011-12-05 19:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 12:53 [Buildroot] [PATCH] Add package connman Daniel Mack
2011-12-05 13:00 ` Baruch Siach
2011-12-05 13:15 ` [Buildroot] [PATCH v2] " Daniel Mack
2011-12-05 14:37 ` Peter Korsgaard
2011-12-05 15:01 ` Baruch Siach
2011-12-05 15:02 ` Daniel Mack
2011-12-05 15:29 ` Peter Korsgaard
2011-12-05 17:26 ` Daniel Mack
2011-12-05 17:30 ` [Buildroot] [PATCH v3] " Daniel Mack
2011-12-05 22:18 ` Peter Korsgaard
2011-12-05 23:07 ` Daniel Mack
2011-12-05 23:13 ` Peter Korsgaard
2011-12-05 23:20 ` Daniel Mack
2011-12-05 23:23 ` Peter Korsgaard
2011-12-05 23:27 ` [Buildroot] [PATCH v4] " Daniel Mack
2011-12-07 19:25 ` Peter Korsgaard
2011-12-05 19:20 ` [Buildroot] [PATCH v2] " Thomas Petazzoni
2011-12-05 19:32 ` Daniel Mack [this message]
2011-12-05 19:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDD1C52.1050907@gmail.com \
--to=zonque@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox