From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] vlc: Patch to get it compiling with qt-embedded
Date: Mon, 27 Feb 2012 10:26:53 +0100 [thread overview]
Message-ID: <4F4B4C5D.4010409@lucaceresoli.net> (raw)
In-Reply-To: <1330256732-26483-2-git-send-email-ismael.luceno@gmail.com>
Ismael Luceno wrote:
> ---
> .../multimedia/vlc/vlc-qt-4.8-embedded-fixes.patch | 33 ++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644 package/multimedia/vlc/vlc-qt-4.8-embedded-fixes.patch
In general you should signoff your patches before submission.
But in the case of this one, it looks like a aprt of your other patch
("vlc: new package"). So it should be in the same commit.
>
> diff --git a/package/multimedia/vlc/vlc-qt-4.8-embedded-fixes.patch b/package/multimedia/vlc/vlc-qt-4.8-embedded-fixes.patch
> new file mode 100644
> index 0000000..61cd586
> --- /dev/null
> +++ b/package/multimedia/vlc/vlc-qt-4.8-embedded-fixes.patch
> @@ -0,0 +1,33 @@
> +--- a/modules/gui/qt4/qt4.cpp 2012-02-23 22:42:45.760340077 -0200
> ++++ b/modules/gui/qt4/qt4.cpp 2012-02-24 00:13:04.878082822 -0200
Here as well you should state why the patch is needed and where
it comes from.
Luca
next prev parent reply other threads:[~2012-02-27 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 11:45 [Buildroot] [PATCH 1/2] vlc: new package Ismael Luceno
2012-02-26 11:45 ` [Buildroot] [PATCH 2/2] vlc: Patch to get it compiling with qt-embedded Ismael Luceno
2012-02-27 9:26 ` Luca Ceresoli [this message]
2012-02-28 20:49 ` Arnout Vandecappelle
2012-02-27 9:16 ` [Buildroot] [PATCH 1/2] vlc: new package Luca Ceresoli
2012-02-27 9:34 ` Peter Korsgaard
2012-02-27 13:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4B4C5D.4010409@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox