From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] imagemagick: Ignore host's xml2-config
Date: Tue, 13 Mar 2012 14:29:10 +0000 [thread overview]
Message-ID: <4F5F59B6.7000002@imgtec.com> (raw)
In-Reply-To: <4F5F56AD.2020408@imgtec.com>
On 03/13/2012 02:16 PM, Markos Chandras wrote:
> On 03/13/2012 02:06 PM, Markos Chandras wrote:
>
>> On 03/13/2012 01:53 PM, Peter Korsgaard wrote:
>>
>>>>>>>> "Markos" == Markos Chandras <markos.chandras@imgtec.com> writes:
>>>
>>> Markos> If $(HOST_DIR)/usr/bin is in the user's $PATH, and host-libxml2 is
>>> Markos> installed, the configure script will find xml2-config in
>>> Markos> $(HOST_DIR)/usr/bin and the xml2-config --prefix will return the
>>> Markos> $(HOST_DIR)/usr. This is bad because imagemagick will append
>>> Markos> -L$(HOST_DIR)/usr/lib to LDFLAGS and it will try to link against
>>> Markos> the host's libraries instead of those located in the staging directory.
>>>
>>> Hmm, is this still a problem? We already have a libxml2 patch for
>>> imagemagick to ensure it picks up the target one, and we explicitly pass
>>> --without-xml if we're not building libxml2 for the target.
>>>
>>> Are you testing against buildroot git? From the the patch file name I
>>> would guess not. Could you retry with latest git and let me know if it
>>> is still needed?
>>>
>>
>> Are you referring to the imagemagick-6.6.4-8-use-xml2-config.patch? If
>> yes, this does not fix the problem because AC_CHECK_PROG() searches for
>> programmes in the $PATH and if $(HOST_DIR)/usr/bin/xml2-config is in the
>> path, it will find that and set xml2_config variable to $(HOST_DIR)/usr
>> which in turn sets LDFLAGS to -L{xml2_config}/lib
>>
>
> Hmm I think you are right. The imagemagick-6.6.4-8-use-xml2-config.patch
> did not apply to my tree. Let me do some further testing and I will
> reply back
>
Yes, for whatever reason the buildroot infrastructure ignored that patch
and never got applied. I guess my tree was broken somehow. Apologies for
the noise. Please ignore my patch.
--
markos
next prev parent reply other threads:[~2012-03-13 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 13:35 [Buildroot] [PATCH] imagemagick: Ignore host's xml2-config Markos Chandras
2012-03-13 13:53 ` Peter Korsgaard
2012-03-13 14:06 ` Markos Chandras
2012-03-13 14:16 ` Markos Chandras
2012-03-13 14:29 ` Markos Chandras [this message]
2012-03-13 15:29 ` Peter Korsgaard
2012-03-13 15:34 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F59B6.7000002@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox