From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] omap-u-boot-utils: add new host package
Date: Mon, 19 Mar 2012 15:56:53 +0100 [thread overview]
Message-ID: <4F674935.5070308@lucaceresoli.net> (raw)
In-Reply-To: <201203181822.28975.arnout@mind.be>
Arnout Vandecappelle wrote:
> On Thursday 15 March 2012 21:54:11 Luca Ceresoli wrote:
> [snip]
>> +#############################################################
>> +#
>> +# omap-u-boot-utils
>> +#
>> +#############################################################
>> +
>> +OMAP_U_BOOT_UTILS_VERSION = 8aff852322
>> +OMAP_U_BOOT_UTILS_SITE = git://github.com/nmenon/omap-u-boot-utils.git
>> +OMAP_U_BOOT_UTILS_SITE_METHOD = git
> SITE_METHOD is actually redundant because it is derived from the
> git:// prefix. Still, I prefer this site method.
>
> OTOH, for the URL, I prefer tu use the http URL. Many company
> firewalls block git traffic.
I think you should start a company-wide petition against such a torture! ;)
Anyway... I used to think github only supports https, but now I found out
also http works, and is is even already used by other BR packages... I'll
resubmit with an http URL.
>
>> +
>> +define HOST_OMAP_U_BOOT_UTILS_BUILD_CMDS
>> + $(MAKE) -C $(@D)
>> +endef
>> +
>> +define HOST_OMAP_U_BOOT_UTILS_INSTALL_CMDS
>> + for f in gpsign pserial tagger ucmd ukermit ; do \
>> + [ -f ${HOST_DIR}/usr/bin/$$f ] || \
> Why this condition? The result is that when you bump the version and
> don't do a make clean, the old version will still be installed in the
> host directory.
Oops, will fix.
Thanks,
Luca
next prev parent reply other threads:[~2012-03-19 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 20:54 [Buildroot] [PATCH v3 0/2] Add omap-u-boot-utils and build .ift OMAP image Luca Ceresoli
2012-03-15 20:54 ` [Buildroot] [PATCH v3 1/2] omap-u-boot-utils: add new host package Luca Ceresoli
2012-03-18 17:22 ` Arnout Vandecappelle
2012-03-19 14:56 ` Luca Ceresoli [this message]
2012-03-15 20:54 ` [Buildroot] [PATCH v3 2/2] u-boot: build signed image for OMAP processors Luca Ceresoli
2012-03-18 17:33 ` Arnout Vandecappelle
2012-03-19 15:24 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F674935.5070308@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox