From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] xfsprogs: Bump to 3.1.7 and convert to AUTOTARGET
Date: Thu, 22 Mar 2012 09:17:48 +0000 [thread overview]
Message-ID: <4F6AEE3C.9020108@imgtec.com> (raw)
In-Reply-To: <20120321184616.19ed7ea2@skate>
On 03/21/2012 05:46 PM, Thomas Petazzoni wrote:
> Hello,
>
> Thanks for this work!
>
> Le Wed, 21 Mar 2012 17:07:15 +0000,
> Markos Chandras <markos.chandras@imgtec.com> a ?crit :
>
>> #############################################################
>> -XFSPROGS_VERSION:=3.0.3
>> +XFSPROGS_VERSION:=3.1.7
>
> We prefer '=' instead of ':=', and spaces before and after '=', i.e:
>
> XFSPROGS_VERSION = 3.1.7
>
>> XFSPROGS_SOURCE=xfsprogs-$(XFSPROGS_VERSION).tar.gz
>
> This line is not needed, it's the default.
>
>> +XFSPROGS_INSTALL_STAGING = NO
>> +XFSPROGS_INSTALL_TARGET = YES
>
> Not needed, it's the default.
>
>>
>> -$(DL_DIR)/$(XFSPROGS_SOURCE):
>> - $(call DOWNLOAD,$(XFSPROGS_SITE)/$(XFSPROGS_SOURCE))
>> +XFSPROGS_DEPENDENCIES = util-linux
>>
>> -xfsprogs-source: $(DL_DIR)/$(XFSPROGS_SOURCE)
>> +XFSPROGS_CONF_ENV = ac_cv_header_aio_h=yes ac_cv_lib_rt_lio_listio=yes
>> +XFSPROGS_CONF_OPT = --enable-lib64=no \
>> + --enable-gettext=no \
>> + INSTALL_USER=default \
>> + INSTALL_GROUP=default
>
> Hum, why default:default and not root:root here? Anyway, our fakeroot
> script is going to chown everything to root:root.
>
> In terms of indentation, something like:
>
> XFSPROGS_CONF_OPT = \
> --enable-lib64=no \
> --enable-gettext=no \
> INSTALL_USER=root \
> INSTALL_GROUP=root
>
> Would be better, IMO, but I'm nitpicking.
>
> Otherwise, looks good (but untested).
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Hi Thomas,
Thanks for the review. A new patch is coming soon
--
markos
next prev parent reply other threads:[~2012-03-22 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 17:07 [Buildroot] [PATCH] xfsprogs: Bump to 3.1.7 and convert to AUTOTARGET Markos Chandras
2012-03-21 17:46 ` Thomas Petazzoni
2012-03-22 9:17 ` Markos Chandras [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 9:34 Markos Chandras
2012-04-05 15:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6AEE3C.9020108@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox