From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] logsurfer: new package
Date: Tue, 15 May 2012 23:23:04 +0200 [thread overview]
Message-ID: <4FB2C938.2000706@mind.be> (raw)
In-Reply-To: <1337067382-19212-1-git-send-email-faessler@was.ch>
Hoi Dominik,
Thank you for your contribution. You patch looks very good, with a few
small remarks.
Please add a Signed-off-by line for yourself. This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more
details.
On 05/15/12 09:36, Dominik F?ssler wrote:
[snip]
> --- /dev/null
> +++ b/package/logsurfer/logsurfer.mk
> @@ -0,0 +1,15 @@
> +#############################################################
> +#
> +# logsurfer
> +#
> +#############################################################
> +
> +LOGSURFER_VERSION = 1.8
> +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz
> +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION}
We try to be consistent in using $() to reference variables, rather than
${}.
> +define LOGSURFER_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin
> +endef
> +
> +$(eval $(call AUTOTARGETS,package,logsurfer))
The arguments to AUTOTARGETS are no longer necessary.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-05-15 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 7:36 [Buildroot] [PATCH] logsurfer: new package Dominik Fässler
2012-05-15 21:23 ` Arnout Vandecappelle [this message]
2012-05-19 18:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2C938.2000706@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox