From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: cJSON
Date: Tue, 05 Jun 2012 01:38:12 +0200 [thread overview]
Message-ID: <4FCD46E4.9020102@mind.be> (raw)
In-Reply-To: <1338432637-10766-1-git-send-email-danomimanchego123@gmail.com>
On 05/31/12 04:50, Danomi Manchego wrote:
> Signed-off-by: Danomi Manchego<danomimanchego123@gmail.com>
[snip]
> +CJSON_VERSION = undefined
> +CJSON_SOURCE = cJSONFiles.zip
> +CJSON_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/cjson/
> +CJSON_INSTALL_STAGING = YES
> +CJSON_INSTALL_TARGET = YES
INSTALL_TARGET = YES is the default so that line can be removed.
> +
> +CJSON_ARCHIVE_DIR = cJSON
I don't really think it's useful to define this as a variable; it doesn't make
the commands below more readable.
> +
> +define CJSON_EXTRACT_CMDS
> + unzip -o -q -d $(@D) $(DL_DIR)/$(CJSON_SOURCE)
We don't use the -o and -q options in the other packages using zip.
Otherwise, looks good.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2012-06-04 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 2:50 [Buildroot] [PATCH] New package: cJSON Danomi Manchego
2012-06-04 23:38 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD46E4.9020102@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox