Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] Bug on host-only packages
Date: Tue, 19 Jun 2012 11:15:10 +0200	[thread overview]
Message-ID: <4FE0431E.9080909@lucaceresoli.net> (raw)
In-Reply-To: <20120611105621.0aacd20c@skate>

Hi Thomas,

Thomas Petazzoni wrote:
> Hello,
>
> I have the impression that there is a bug on the download step of
> host-only packages: the tarballs are named host-foobar-xxx.tar.gz
> instead of just foobar-xxx.tar.gz. For example, in my download
> directory, I have:
>
> host-lpc3250loader-1.0.tar.gz
> host-omap-u-boot-utils-8aff852322.tar.gz
>
> Even though those don't have target variants (so there is no
> problematic consequences to this bug), I think that for consistency
> reasons they should be named:
>
> lpc3250loader-1.0.tar.gz
> omap-u-boot-utils-8aff852322.tar.gz
>
> Most likely a bug in the GENTARGETS infrastructure. I haven't look at
> the code yet, I'm just reporting the issue (don't have the time to dig
> into it right now).

I noticed this problem as well. It seems to be caused by the fact that
DOWNLOAD_INNER passes $(1) and $(2) to the DOWNLOAD_WGET, which contain the
correct info, while it passes nothing to other downloaders, which have to
do on their own based on $($(PKG)_SOURCE). The latter is in turn undefined
for git (and other) methods, so it defaults to $(2)_BASE_NAME, which has the
"host-" prefix.

I had no time to go on and fix the issue properly.

Slightly off topic, I think we should consider having an extra argument to
GENTARGETS_INNER holding the lowercase package name, without the 
host-prefix,
as we do for the uppercase package name.
This would ease further operations and, ultimately, fixing the bug in 
discussion.

All of these are in my todo list (obviously unscheduled).

Luca

  reply	other threads:[~2012-06-19  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11  8:56 [Buildroot] Bug on host-only packages Thomas Petazzoni
2012-06-19  9:15 ` Luca Ceresoli [this message]
2012-10-14 15:17 ` [Buildroot] [PATCH] pkg-infra: correct the source name for " Arnout Vandecappelle
2012-10-14 17:55   ` Thomas Petazzoni
2012-10-15  7:29   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE0431E.9080909@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox