Re: [Buildroot] [PATCH v2] package/cog: add libgbm as dependency when building with DRM support

[Michael Nosthoff via buildroot <buildroot@buildroot.org>]

Hi,

On Saturday, July 23, 2022 10:48 CEST, Arnout Vandecappelle <arnout@mind.be> wrote:

> 
> 
> On 22/07/2022 09:01, Alexandru Ardelean wrote:
> > When building with the DRM support, it can happen that the libgbm library
> > is not yet built by the provider of this lib (specified by
> > BR2_PACKAGE_PROVIDES_LIBGBM).
> 
>   I've applied this one to master already, however there are two comments on v1 
> that remain unaddressed.
> 
> > 
> > The docs in cog `docs/platform-drm.md` specify this dep-list:
> > - **WPEBackend-fdo**:
> > - **Wayland**:
> > - **libdrm**:
> > - **libgbm**:
> > - **libinput**:
> > - **libudev**:
> 
>   This would imply that a dependency on udev is needed as well (both in the 
> Config.in and the .mk). It is actually implied by libinput, so we won't get 
> build failures, but it's better to have explicit dependencies.
> 
> > 
> > libgbm needs to be added.
> > Adding libegl as well.
> > 
> > Updated package/cog/Config.in to define the dependencies (for DRM)
> > according to libegl & libgbm.
> > 
> > Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> > ---
> >   package/cog/Config.in | 9 ++++++---
> >   package/cog/cog.mk    | 2 +-
> >   2 files changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/package/cog/Config.in b/package/cog/Config.in
> > index d4238750f9..484eb85c70 100644
> > --- a/package/cog/Config.in
> > +++ b/package/cog/Config.in
> > @@ -39,7 +39,8 @@ config BR2_PACKAGE_COG_PLATFORM_FDO
> >   config BR2_PACKAGE_COG_PLATFORM_DRM
> >   	bool "DRM backend"
> >   	depends on BR2_PACKAGE_HAS_UDEV # libinput
> > -	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # gbm
> > +	depends on BR2_PACKAGE_HAS_LIBEGL
> > +	depends on BR2_PACKAGE_HAS_LIBGBM
> 
>   It apparently needs the 
> BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_MODIFIER_PLANE_COUNT feature. You can test 
> that by trying a build with rockchip-mali or ti-sgx-um as provider, since those 
> packages don't have that feature.
> 

I'm currently maintaining an external package for the newest ti-sgx-um version which provides
(i think) a newer/more complete version of libegl/libgbm. For this I currently have to patch
the cog package but the output is working fine with the drm backend.
So I would be highly interested in a patch like this.

Is there a way to find out which features a certain libegl/libgbm provides? Maybe I can then pick-up
the work on bumping the ti-sgx-um/km packages again to bring them to a more recent version.

Regards,
Michael

> 
>   Regards,
>   Arnout
> 
> >   	select BR2_PACKAGE_LIBDRM
> >   	select BR2_PACKAGE_LIBINPUT
> >   	help
> > @@ -52,7 +53,9 @@ config BR2_PACKAGE_COG_USE_SYSTEM_DBUS
> >   	help
> >   	  Expose remote control interface on system bus
> >   
> > -comment "DRM platform needs mesa3d w/ EGL driver and GBM"
> > -	depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL
> > +comment "DRM platform needs EGL and GBM"
> > +	depends on \
> > +		!BR2_PACKAGE_HAS_LIBEGL || \
> > +		!BR2_PACKAGE_HAS_LIBGBM
> >   
> >   endif
> > diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> > index f2ca0af93d..da660eb7c1 100644
> > --- a/package/cog/cog.mk
> > +++ b/package/cog/cog.mk
> > @@ -28,7 +28,7 @@ endif
> >   
> >   ifeq ($(BR2_PACKAGE_COG_PLATFORM_DRM),y)
> >   COG_CONF_OPTS += -DCOG_PLATFORM_DRM=ON
> > -COG_DEPENDENCIES += libdrm libinput
> > +COG_DEPENDENCIES += libdrm libinput libgbm libegl
> >   else
> >   COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF
> >   endif
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot