From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnout Vandecappelle <arnout@mind.be>
Date: Fri, 25 Oct 2019 22:40:14 +0200
Subject: [Buildroot] [PATCH] package/qemu: enable usb passthrough on
 host variant
In-Reply-To: <87h83x4ys7.fsf@dell.be.48ers.dk>
References: <20191024202820.18814-1-angelo@amarulasolutions.com>
 <20191024223639.28125bf8@windsurf.home> <87h83x4ys7.fsf@dell.be.48ers.dk>
Message-ID: <4e00d6ec-752a-e35d-b586-47703369c07e@mind.be>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net



On 24/10/2019 23:30, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> 
>  >> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
> 
>  > So, if the target libusb package is enabled...
> 
>  >> +HOST_QEMU_OPTS += --enable-libusb
>  >> +HOST_QEMU_DEPENDENCIES += host-libusb
> 
>  > ... you assume the user wants libusb support in host-qemu.
> 
>  > Sorry, but this is not good. Add an option in
>  > package/qemu/Config.in.host to enable USB passthrough, and use that in
>  > qemu.mk.

 host-libusb takes 1 second to build (*). Is it really worth to make an option
for it?

 Regards,
 Arnout

(*) Yes, I'm exaggerating :-)

> 
> And pass --disable-libusb (if such option exists) in the else clause.
>