Re: [Buildroot] [PATCH 1/1] package/ncmpc: bump version to 0.52

[Andreas Ziegler <br015@umbiko.net>]

Hi Tim, *

Do you have any idea why the libatomic patch is now obsolete? The 
regression test 
(http://autobuild.buildroot.org/results/7ac1a07e4f72633d3ec92b79dc5d8c062490abdc) 
builds (after removing a lot of legacy config options).

You have spaces instead of tabs in Config.in, please see the comment 
below.

Kind regards,
Andreas


On 2025-07-08 15:17, Tim Soubry wrote:
> 
> Applying version bump of ncmpc to version 0.52 as proposed in [1].
> As from version 0.50 of ncmpc, fmt got added as a dependency [2]. This 
> was
> also added to package/ncmpc/Config.in and package/ncmpc/ncmpc.mk.
> 
> For release notes, see:
> https://github.com/MusicPlayerDaemon/ncmpc/blob/master/NEWS
> 
> Comparision between version 0.49 and 0.52:
> https://github.com/MusicPlayerDaemon/ncmpc/compare/v0.49..v0.52
> 
> [1] 
> https://lore.kernel.org/buildroot/20250707112536.1644236-1-tim.soubry@mind.be/T/#rb3b968fff23bac0298e33f473d63a1ad470d38e3
> [2] 
> https://github.com/MusicPlayerDaemon/ncmpc/commit/c3b0055d06f8e8efab7f388646beb7645b90d063
> 
> Signed-off-by: Tim Soubry <tim.soubry@mind.be>
> ---
>  ...cro-my_gettext-do-not-define-gettext.patch | 199 ------------------
>  ...uild-add-atomic-dependency-for-sparc.patch |  45 ----
>  package/ncmpc/Config.in                       |   5 +-
>  package/ncmpc/ncmpc.hash                      |   2 +-
>  package/ncmpc/ncmpc.mk                        |   3 +-
>  5 files changed, 6 insertions(+), 248 deletions(-)
>  delete mode 100644 
> package/ncmpc/0001-i18n-add-macro-my_gettext-do-not-define-gettext.patch
>  delete mode 100644 
> package/ncmpc/0001-meson.build-add-atomic-dependency-for-sparc.patch

<elision>

> diff --git a/package/ncmpc/Config.in b/package/ncmpc/Config.in
> index 61c186a4ae..e4bda449e3 100644
> --- a/package/ncmpc/Config.in
> +++ b/package/ncmpc/Config.in
> @@ -5,8 +5,9 @@ config BR2_PACKAGE_NCMPC
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 # C++20
> -	select BR2_PACKAGE_LIBMPDCLIENT
> -	select BR2_PACKAGE_NCURSES
> +	select BR2_PACKAGE_FMT
> +       select BR2_PACKAGE_LIBMPDCLIENT
> +       select BR2_PACKAGE_NCURSES

    ^^^ utils/check-package complains here.

>  	help
>  	  ncmpc is a fully featured MPD client, which runs in a terminal
>  	  (using ncurses). Its goal is to provide a keyboard oriented
> diff --git a/package/ncmpc/ncmpc.hash b/package/ncmpc/ncmpc.hash
> index 1d288294d1..41cfd86584 100644
> --- a/package/ncmpc/ncmpc.hash
> +++ b/package/ncmpc/ncmpc.hash
> @@ -1,5 +1,5 @@
>  # Locally calculated after checking pgp signature
> -sha256  
> 65bbec0ede9e6bcf62ac647b0c706485beb2bdd5db70ca8d60103f32f162cf29  
> ncmpc-0.49.tar.xz
> +sha256  
> 3af225496fe363a8534a9780fb46ae1bd17baefd80cf4ba7430a19cddd73eb1a  
> ncmpc-0.52.tar.xz
> 
>  # Hash for license file:
>  sha256  
> ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  
> COPYING
> diff --git a/package/ncmpc/ncmpc.mk b/package/ncmpc/ncmpc.mk
> index ee75c2a676..726f524bfa 100644
> --- a/package/ncmpc/ncmpc.mk
> +++ b/package/ncmpc/ncmpc.mk
> @@ -5,13 +5,14 @@
>  
> ################################################################################
> 
>  NCMPC_VERSION_MAJOR = 0
> -NCMPC_VERSION = $(NCMPC_VERSION_MAJOR).49
> +NCMPC_VERSION = $(NCMPC_VERSION_MAJOR).52
>  NCMPC_SOURCE = ncmpc-$(NCMPC_VERSION).tar.xz
>  NCMPC_SITE = 
> http://www.musicpd.org/download/ncmpc/$(NCMPC_VERSION_MAJOR)
>  NCMPC_DEPENDENCIES = \
>  	host-pkgconf \
>  	libmpdclient \
>  	ncurses \
> +	fmt \
>  	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
>  	$(TARGET_NLS_DEPENDENCIES)
>  NCMPC_LICENSE = GPL-2.0+
> --
> 2.39.5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot