From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 17 Jul 2012 09:34:17 +0200 Subject: [Buildroot] [PATCH 1 of 6 resend] pkg-download.mk: allow using localfiles outside of package infrastructure In-Reply-To: References: <1dcdff3e9437fc63cd4b.1340343754@beantl019720> <5002A868.70107@mind.be> Message-ID: <50051579.3010704@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 07/16/12 05:14, Thomas De Schampheleire wrote: > Hi Arnout, > > Thanks for your review and acks. Thanks for your feedback, this gets my Acked-by: Arnout Vandecappelle (Essensium/Mind) > > Op 15 jul. 2012 05:24 schreef "Arnout Vandecappelle" > het volgende: >> >> On 06/22/12 07:42, Thomas De Schampheleire wrote: >> > >> > The localfiles download method uses $($(PKG)_SITE))) and >> > $($(PKG)_SOURCE) instead of $(1) and $(2). This means that it can only >> > be used for package downloads (through gentargets, autotargets, ...) >> > and not for other downloads like external toolchains. >> > >> > This patch changes localfiles to allow this, just as the wget and scp >> > download methods already did. >> > For the version control download methods, nothing changes. >> >> >> Is there any reason not to do it for the VCS download methods? >> > > Just because I didn't really see how you'd use that. For non-package downloads you'd be downloading a single file > (typically a tarball). It seems odd to me to take that from a version control system. I guess you'll need to express the > version you want in the URL, which may not be possible for all the systems we support. > Thomas basically asked the same question. Do any of you do see a use case? It's just for symmetry as far as I'm concerned. It's true that the VCS methods require a revision as well, so they'll also require the $(PKG) to be used. Taking a tarball from a VCS is not even possible with the current VCS download methods: they would pack the tarball into another tarball... > >> >> > >> > Signed-off-by: Thomas De Schampheleire> >> > >> > --- >> > package/pkg-download.mk | 8 ++++---- >> > 1 files changed, 4 insertions(+), 4 deletions(-) >> > >> > diff --git a/package/pkg-download.mk b/package/pkg-download.mk >> > --- a/package/pkg-download.mk >> > +++ b/package/pkg-download.mk >> > @@ -174,16 +174,16 @@ define SHOW_EXTERNAL_DEPS_WGET >> > endef >> > >> > define DOWNLOAD_LOCALFILES >> > - test -e $(DL_DIR)/$($(PKG)_SOURCE) || \ >> > - $(LOCALFILES) $(call qstrip,$(subst file://,,$($(PKG)_SITE)))/$($(PKG)_SOURCE) $(DL_DIR) >> > + test -e $(DL_DIR)/$(2) || \ >> > + $(LOCALFILES) $(call qstrip,$(subst file://,,$(1))) $(DL_DIR) >> >> >> Shouldn't this be >> $(LOCALFILES) $(call qstrip,$(subst file://,,$(1))) $(DL_DIR)/$(2) > > Well, the behavior is the same as before. But I guess you could safely add the explicit destination. I can't test it as > I'm on holiday, though. > > Maybe you could submit that as a separate patch? OK. [snip] Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F