Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] luaexpat: Add license info
Date: Fri, 03 Aug 2012 10:30:26 +0200	[thread overview]
Message-ID: <501B8C22.7040208@lucaceresoli.net> (raw)
In-Reply-To: <1343962432-2772-5-git-send-email-danomimanchego123@gmail.com>

Danomi Manchego wrote:
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>   package/luaexpat/luaexpat.mk |    8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/luaexpat/luaexpat.mk b/package/luaexpat/luaexpat.mk
> index 400d7b4..c875caa 100644
> --- a/package/luaexpat/luaexpat.mk
> +++ b/package/luaexpat/luaexpat.mk
> @@ -4,9 +4,11 @@
>   #
>   #############################################################
>   
> -LUAEXPAT_VERSION      = 1.2.0
> -LUAEXPAT_SITE         = http://matthewwild.co.uk/projects/luaexpat
> -LUAEXPAT_DEPENDENCIES = lua expat
> +LUAEXPAT_VERSION       = 1.2.0
> +LUAEXPAT_SITE          = http://matthewwild.co.uk/projects/luaexpat
> +LUAEXPAT_DEPENDENCIES  = lua expat
> +LUAEXPAT_LICENSE       = MIT
> +LUAEXPAT_LICENSE_FILES = doc/us/license.html

Ouch, putting the license in an HTML file is very strange!
The license.txt file produces by `make legal-info` is supposed to be a
text file, not a mix of different formats.

I have no strong opinion about what to do here, but I slightly prefer to
not define LUAEXPAT_LICENSE_FILES in this case, since it cannot work 100%
as expected. Asking the developers to use a standard format may be a good
idea as well.

Luca

  reply	other threads:[~2012-08-03  8:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  2:53 [Buildroot] [PATCH 1/6] cjson: Add license info Danomi Manchego
2012-08-03  2:53 ` [Buildroot] [PATCH 2/6] expat: " Danomi Manchego
2012-08-03  8:41   ` Luca Ceresoli
2012-08-03  2:53 ` [Buildroot] [PATCH 3/6] lua: " Danomi Manchego
2012-08-03  8:41   ` Luca Ceresoli
2012-08-03  2:53 ` [Buildroot] [PATCH 4/6] luacjson: " Danomi Manchego
2012-08-03  8:41   ` Luca Ceresoli
2012-08-03  2:53 ` [Buildroot] [PATCH 5/6] luaexpat: " Danomi Manchego
2012-08-03  8:30   ` Luca Ceresoli [this message]
2012-08-03  2:53 ` [Buildroot] [PATCH 6/6] xinetd: " Danomi Manchego
2012-08-03  8:18   ` Luca Ceresoli
2012-08-04  2:56     ` Danomi Manchego
2012-08-03  8:30 ` [Buildroot] A little summer game ? :-) Thomas Petazzoni
2012-08-03  9:04   ` Luca Ceresoli
2012-08-03  9:19     ` Thomas Petazzoni
2012-08-03 11:07       ` Thomas De Schampheleire
2012-08-03 11:35         ` Thomas Petazzoni
2012-08-03  8:38 ` [Buildroot] [PATCH 1/6] cjson: Add license info Luca Ceresoli
2012-08-04  3:05   ` Danomi Manchego
2012-08-04 12:46 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501B8C22.7040208@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox