From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Liu Date: Sun, 12 Aug 2012 18:51:04 +1000 Subject: [Buildroot] [PATCH] nodejs: new package In-Reply-To: <20120812090610.6cf8fd4d@skate> References: <1344665495-27246-1-git-send-email-net147@gmail.com> <20120811222306.4e21b827@skate> <502703DF.5000602@gmail.com> <20120812090610.6cf8fd4d@skate> Message-ID: <50276E78.3030009@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Thomas, On 12/08/2012 5:06 PM, Thomas Petazzoni wrote: > It would be better if Node.js could use the OpenSSL version that is in > Buildroot rather than its own internal one. It avoids having two copies > of OpenSSL on the target system. > > And yes, if the SSL support can be enabled/disabled easily, it would be > great: OpenSSL is a fairly heavy dependency. Done. > >>>> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk >>>> new file mode 100644 >>>> index 0000000..8a0fa91 >>>> --- /dev/null >>>> +++ b/package/nodejs/nodejs.mk >>>> @@ -0,0 +1,54 @@ >>>> +############################################################# >>>> +# >>>> +# nodejs >>>> +# >>>> +############################################################# >>>> +NODEJS_VERSION = 0.8.6 >>>> +NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz >>>> +NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION) >>>> +NODEJS_INSTALL_STAGING = YES >>> Does NodeJS contains libraries required by other packages? >> The headers and node-waf binary are needed to build 3rd party native >> modules. I figured it may be useful if someone wants to create buildroot >> packages for node.js modules in the future. > Can you add a comment with a similar explanation just before this line. > For libraries, the reason to have _INSTALL_STAGING is fairly obvious, > for things like nodejs, it's a little bit less obvious for the ones who > are not familiar with what nodejs is. Done. I've submitted the updated patch as V3. Regards, Jonathan