Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 10/12] pkg-infra: ensure gettext gets built before all other packages
Date: Sun, 02 Sep 2012 22:30:48 +0200	[thread overview]
Message-ID: <5043C1F8.6020801@mind.be> (raw)
In-Reply-To: <1346600635-30946-11-git-send-email-yann.morin.1998@free.fr>

On 09/02/12 17:43, Yann E. MORIN wrote:
> If the gettext package is selected, it means that the toolchain does not
> provide gettext functionality, and that at least one package needs it.
> Thus, the gettext package needs to be built before any such package.
>
> So far, packages that need gettext declare an explicit conditional
> build-dependency upon gettext, thus ensuring that gettext be built
> before they are.
>
> But if gettext was built first, packages would no longer need to declare
> such an explicit build-dependency.
>
> As it is not easy to ensure that gettext be the first package, we can also
> declare it as a dependency of all packages (except itself, of course).


  I don't like this.  I don't like the idea of having redundant dependencies,
I don't like to have a single thing that everything depends on, I don't like
the $(filter-out ...) construct.

  I also don't like that it breaks the build when the toolchain depends on some
package (sstrip, ccache, ...).

  Possible alternatives:

  * Use a construct similar to patch 11/12: $(gettext-dependency) which is
nothing unless gettext is enabled.

  * Move this dependency into the toolchain logic - which means duplicating
it three times so maybe not such a good idea...


  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-09-02 20:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02 15:43 [Buildroot] [PATCH 0/12] Rework the gettext handling Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 01/12] gettext: remove option to build statically Yann E. MORIN
2012-09-03  9:01   ` Arnout Vandecappelle
2012-09-03  9:21     ` Yann E. MORIN
2012-09-03 18:02     ` Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 02/12] gettext: remove the gettext-target make target, unused Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 03/12] gettext: remove libintl handling Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 04/12] Remove all references to libintl Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 05/12] gettext: convert to autotools-package Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 06/12] doc: update after gettext changes Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 07/12] package/lshw: add missing dependency on gettext Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 08/12] package/pulseaudio: fix build-dependency " Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 09/12] toolchain/common: rename BR2_NEEDS_GETTEXT Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 10/12] pkg-infra: ensure gettext gets built before all other packages Yann E. MORIN
2012-09-02 20:30   ` Arnout Vandecappelle [this message]
2012-09-02 21:05     ` Yann E. MORIN
2012-09-03  7:48       ` Arnout Vandecappelle
2012-09-03  9:09     ` Thomas Petazzoni
2012-09-03  9:38       ` Arnout Vandecappelle
2012-09-02 15:43 ` [Buildroot] [PATCH 11/12] toolchain/common: introduce blind options BR2_NEEDS_GETTEXT{, _IF_LOCALE} Yann E. MORIN
2012-09-02 15:43 ` [Buildroot] [PATCH 12/12] packages: use the new gettext mechanism Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5043C1F8.6020801@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox