From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2][RESEND] python-protobuf: Add support for Python implementation of Google's Protocol Buffers
Date: Thu, 20 Sep 2012 23:40:18 +0200 [thread overview]
Message-ID: <505B8D42.8010108@mind.be> (raw)
In-Reply-To: <20120920223439.6480353a@skate>
On 09/20/12 22:34, Thomas Petazzoni wrote:
>> > +PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
>> > +PYTHON_PROTOBUF_SOURCE = $(PROTOBUF_SOURCE)
>> > +PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
> So the source tarball is the same? So what you're doing here in fact is
> having two separate Buildroot packages for the same source tarball,
> something that we generally don't do. But in this case, it seems like
> logical to do it this way.
>
> What do others think about this strategy?
>
It's a good start, but I still think we need more generic infrastructure
for this use case. For instance, this will fail if protobuf moves to a
hg version, because then PROTOBUF_SOURCE is empty.
For the time being, it's OK, however.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-09-20 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 10:51 [Buildroot] [PATCHv2][RESEND] python-protobuf: Add support for Python implementation of Google's Protocol Buffers Thiago A. Correa
2012-09-20 20:34 ` Thomas Petazzoni
2012-09-20 21:40 ` Arnout Vandecappelle [this message]
2012-10-05 17:55 ` Thiago A. Corrêa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B8D42.8010108@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox