Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] pkgconf: new package
Date: Tue, 25 Sep 2012 18:00:54 -0300	[thread overview]
Message-ID: <50621B86.7040307@zacarias.com.ar> (raw)
In-Reply-To: <506219E1.5070508@mind.be>

On 09/25/12 17:53, Arnout Vandecappelle wrote:

>  Since we anyway need a wrapper, wouldn't it be more consistent
> to set PKG_CONFIG_PATH there instead?

Yes, it's possible, i can't think of any gain by doing so, but then i
can't think of any loss either.

>  As long as pkg-config exists, I would wrap this in a
> ifeq ($(BR2_PACKAGE_PKG_CONFIG),)

See next point...

>  If for whatever reason, host-pkg-config is also built, the script
> will be overwritten.  So to be safe, I'd remove host-pkg-config as well
> (as a third patch).

Yes, the idea is to remove pkg-config, but i don't think this is a final
patch yet, it's more like a "let people test it and see if nothing
breaks" (things didn't break for a couple of projects i've run with the
patchset, but that may not be the case for everyone else).

>  Although this is just copy-pasted from pkg-config.mk, that's no reason
> to break the buildroot conventions :-)
> 
> PKG_CONFIG_HOST_BINARY = $(HOST_DIR)/usr/bin/pkg-config

Yeah, it was a copy, again, not a final patchset :)
Regards.

      reply	other threads:[~2012-09-25 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 19:08 [Buildroot] [PATCH 1/2] pkgconf: new package Gustavo Zacarias
2012-09-25 19:08 ` [Buildroot] [PATCH 2/2] packages: switch to pkgconf Gustavo Zacarias
2012-09-25 20:53 ` [Buildroot] [PATCH 1/2] pkgconf: new package Arnout Vandecappelle
2012-09-25 21:00   ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50621B86.7040307@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox