From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] wpa-supplicant: rework .config file editing
Date: Tue, 25 Sep 2012 23:56:32 +0200 [thread overview]
Message-ID: <50622890.2000107@mind.be> (raw)
In-Reply-To: <1348577725-12647-5-git-send-email-s.neumann@raumfeld.com>
On 09/25/12 14:55, Sven Neumann wrote:
> Further simplify the edits on the .config file based on a nice idea
> brought up by Arnout Vandecappelle on the mailing-list.
>
> Signed-off-by: Sven Neumann<s.neumann@raumfeld.com>
Having it as separate patches doesn't make review easier...
> ---
> package/wpa_supplicant/wpa_supplicant.mk | 117 +--
> raumfeld/br2-remotecontrol-arm.config | 1284 ++++++++++++++++++++++++++++++
Seems to be a mistake here :-)
[snip]
> + cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
> + sed -i $(patsubst %,-e 's/^\(%\)/#\1/',$(WPA_SUPPLICANT_CONFIG_DISABLE)) \
> + $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
> + $(patsubst %,-e '1i%=y',$(WPA_SUPPLICANT_CONFIG_SET)) \
> + $(patsubst %,-e %,$(WPA_SUPPLICANT_CONFIG_EDITS)) \
> + $(WPA_SUPPLICANT_CONFIG)
Yet more whitespace problems :-) Commands should start with a tab,
continuation lines with a tab and then spaces (if you want to align)
or another tab (if you just want to indent).
> endef
>
> define WPA_SUPPLICANT_BUILD_CMDS
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-09-25 21:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 12:55 [Buildroot] wpa_supplicant changes, the next round Sven Neumann
2012-09-25 12:55 ` [Buildroot] [PATCH 1/4] wpa-supplicant: add options to enable the new DBus interface Sven Neumann
2012-09-25 12:55 ` [Buildroot] [PATCH 2/4] wpa_supplicant: remove redundant escaping from sed commands Sven Neumann
2012-09-25 12:55 ` [Buildroot] [PATCH 3/4] wpa_supplicant: introduce macros for editing the .config file Sven Neumann
2012-09-25 12:55 ` [Buildroot] [PATCH 4/4] wpa-supplicant: rework .config file editing Sven Neumann
2012-09-25 21:56 ` Arnout Vandecappelle [this message]
2012-09-27 14:15 ` [Buildroot] wpa_supplicant changes Sven Neumann
2012-09-27 14:15 ` [Buildroot] [PATCH 1/2] wpa-supplicant: add options to enable the new DBus interface Sven Neumann
2012-09-27 14:15 ` [Buildroot] [PATCH 2/2] wpa_supplicant: rework .config file editing Sven Neumann
2012-09-27 22:44 ` Arnout Vandecappelle
2012-09-28 7:05 ` Sven Neumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50622890.2000107@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox