Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Valentine Barshak <gvaxon@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sylpheed: Fix includedir
Date: Sat, 06 Oct 2012 22:51:34 +0400	[thread overview]
Message-ID: <50707DB6.5090401@gmail.com> (raw)
In-Reply-To: <506F6CC2.6050007@mind.be>

On 10/06/2012 03:26 AM, Arnout Vandecappelle wrote:
> On 05/10/12 19:25, Valentine Barshak wrote:
>> The sylpheed headers are installed to the target directory,
>> creating full staging directory path in the target rootfs,
>> which is wrong.
>> This happens because the headers are installed to
>> $(DESTDIR)$(includedir), while DESTDIR is set to
>> $(TARGET_DIR) and includedir is $(STAGING_DIR)/usr/include.
>>
>> Remove $(DESTDIR) from the include paths in the Makefile
>> to have sylpheed install its headers to staging include
>> directory instead.
>
>   Actually, includedir should be /usr/include instead of
> $(STAGING_DIR)/usr/include.  Peter set it to $(STAGING_DIR)/usr/include
> because sylpheed incorrectly adds includedir to its include path.
> So maybe it's better to patch src/Makefile and remove the
> --includedir=... from sylpheed.mk.

Right, I'll submit an updated patch that I've prepared and tested on the 
vmware.

BTW, are there any objections to bump it to version 3.2, which is the 
latest. It seems to work fine for me (though to be honest I haven't seen 
any issues with 3.1 either). Version 3.2 needs the same includedir fix 
as well.

Thanks,
Val.

>
>   Regards,
>   Arnout
>

  reply	other threads:[~2012-10-06 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 17:25 [Buildroot] [PATCH] sylpheed: Fix includedir Valentine Barshak
2012-10-05 23:26 ` Arnout Vandecappelle
2012-10-06 18:51   ` Valentine Barshak [this message]
2012-10-07 11:06     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50707DB6.5090401@gmail.com \
    --to=gvaxon@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox