From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: Fix initramfs compression
Date: Sun, 07 Oct 2012 13:31:53 +0200 [thread overview]
Message-ID: <50716829.7010004@mind.be> (raw)
In-Reply-To: <1349551332-25169-1-git-send-email-gvaxon@gmail.com>
On 06/10/12 21:22, Valentine Barshak wrote:
> - $(call KCONFIG_DISABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_NONE,$(@D)/.config)
> - $(call KCONFIG_ENABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_GZIP,$(@D)/.config))
> + for c in GZIP BZIP2 LZMA XZ LZO; do \
> + if grep -qm1 "CONFIG_RD_$$c=y" $(@D)/.config; then \
> + $(call KCONFIG_DISABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_NONE,$(@D)/.config); \
> + $(call KCONFIG_ENABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_$$c,$(@D)/.config); \
> + break; \
> + fi; \
> + done)
I think this is a bit too complex for something that won't really be used by
most people. Why not just remove the COMPRESSION lines from linux.mk? Then
we fall back on the default if the user hasn't configured it explicitly. Gives
the user the possibility to choose something else than the default, without adding
complexity to buildroot.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-10-07 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 19:22 [Buildroot] [PATCH] linux: Fix initramfs compression Valentine Barshak
2012-10-07 11:31 ` Arnout Vandecappelle [this message]
2012-10-07 20:22 ` Valentine Barshak
2012-10-08 7:43 ` Arnout Vandecappelle
2012-10-09 22:44 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50716829.7010004@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox