Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ludovic.desroches <ludovic.desroches@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fb-test-app: new package
Date: Mon, 8 Oct 2012 09:23:50 +0200	[thread overview]
Message-ID: <50727F86.5050101@atmel.com> (raw)
In-Reply-To: <506F69C8.2010907@mind.be>

Hi Arnout

Le 10/06/2012 01:14 AM, Arnout Vandecappelle a ?crit :
> On 05/10/12 15:31, ludovic.desroches at atmel.com wrote:
>> From: Ludovic Desroches<ludovic.desroches@atmel.com>
>
> Add a Signed-off-by line for yourself.  This is a short way for you to
> assert that you are entitled to contribute the patch under buildroot's
> GPL license.  See  http://kerneltrap.org/files/Jeremy/DCO.txt for more
> details.

Sorry for the omission.

>
> [snip]
>> diff --git a/package/fb-test-app/Config.in
>> b/package/fb-test-app/Config.in
>> new file mode 100644
>> index 0000000..6b682ce
>> --- /dev/null
>> +++ b/package/fb-test-app/Config.in
>> @@ -0,0 +1,4 @@
>> +config BR2_PACKAGE_FB_TEST_APP
>> +    bool "fb-test-app"
>> +    help
>> +      Test suite for Linux framebuffer.
>
>   Could you add an upstream URL to the help text?
>

Yes I'll add the github url.

>> diff --git a/package/fb-test-app/fb-test-app.mk
>> b/package/fb-test-app/fb-test-app.mk
>> new file mode 100644
>> index 0000000..ce31f05
>> --- /dev/null
>> +++ b/package/fb-test-app/fb-test-app.mk
>> @@ -0,0 +1,34 @@
>> +#############################################################
>> +#
>> +# fb-test-app
>> +#
>> +#############################################################
>> +
>> +FB_TEST_APP_VERSION = v1.0.0
>> +FB_TEST_APP_SITE = git://github.com/prpplague/fb-test-app.git
>
> FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball
>
>   downloads a lot faster.

Ok I'll change it.

Regards

Ludovic

>
>   Otherwise, looks great.
>
>
>   Regards,
>   Arnout
>
> [snip]
>
>

  reply	other threads:[~2012-10-08  7:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 13:31 [Buildroot] [PATCH] fb-test-app: new package ludovic.desroches at atmel.com
2012-10-05 23:14 ` Arnout Vandecappelle
2012-10-08  7:23   ` ludovic.desroches [this message]
2012-10-06 21:03 ` Baruch Siach
2012-10-08  7:26   ` ludovic.desroches
2012-10-08  9:05     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50727F86.5050101@atmel.com \
    --to=ludovic.desroches@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox