Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Grégory Hermant" <gregory.hermant@calao-systems.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] at91bootstrap: fix gcc-4.6.x overlap linker issue
Date: Tue, 09 Oct 2012 18:37:43 +0200	[thread overview]
Message-ID: <507452D7.7010503@calao-systems.com> (raw)
In-Reply-To: <87txu43f30.fsf@macbook.be.48ers.dk>

Hello peter,
You are right there's no need to add the code below in the linker script to fix this issue.
Thanks for your time.
gregory

Le 08/10/2012 22:04, Peter Korsgaard a ?crit :
>>>>>> "Gr?gory" == Gr?gory Hermant <gregory.hermant@calao-systems.com> writes:
> 
>  Gr?gory> ---
>  Gr?gory>  ...at91bootstrap-1.16-gcc-4.6.x-ldscript-fix.patch |   53 ++++++++++++++++++++
>  Gr?gory>  1 file changed, 53 insertions(+)
>  Gr?gory>  create mode 100644 boot/at91bootstrap/at91bootstrap-1.16-gcc-4.6.x-ldscript-fix.patch
> 
>  Gr?gory> diff --git a/boot/at91bootstrap/at91bootstrap-1.16-gcc-4.6.x-ldscript-fix.patch b/boot/at91bootstrap/at91bootstrap-1.16-gcc-4.6.x-ldscript-fix.patch
>  Gr?gory> new file mode 100644
>  Gr?gory> index 0000000..56947c7
>  Gr?gory> --- /dev/null
>  Gr?gory> +++ b/boot/at91bootstrap/at91bootstrap-1.16-gcc-4.6.x-ldscript-fix.patch
>  Gr?gory> @@ -0,0 +1,53 @@
>  Gr?gory> +From 5a094e959cd216c1be148effc624eb12e2083de9 Mon Sep 17 00:00:00 2001
>  Gr?gory> +From: Gregory Hermant <gregory.hermant@calao-systems.com>
>  Gr?gory> +Date: Mon, 1 Oct 2012 16:54:43 +0200
>  Gr?gory> +Subject: [PATCH] at91bootstrap-v1.16-ldscript-fix
>  Gr?gory> +
>  Gr?gory> +---
>  Gr?gory> + crt0_gnu.S          |    2 +-
>  Gr?gory> + elf32-littlearm.lds |   12 +++++++++++-
>  Gr?gory> + 2 files changed, 12 insertions(+), 2 deletions(-)
>  Gr?gory> +
>  Gr?gory> +diff --git a/crt0_gnu.S b/crt0_gnu.S
>  Gr?gory> +index 002feef..ea6581f 100644
>  Gr?gory> +--- a/crt0_gnu.S
>  Gr?gory> ++++ b/crt0_gnu.S
>  Gr?gory> +@@ -191,7 +191,7 @@ _go:
>  Gr?gory> + + 	.align
>  Gr?gory> + _lp_data:
>  Gr?gory> +-        .word _etext
>  Gr?gory> ++        .word _edummy
>  Gr?gory> +         .word _sdata
>  Gr?gory> +         .word _edata
>  Gr?gory> + +diff --git a/elf32-littlearm.lds b/elf32-littlearm.lds
>  Gr?gory> +index a33952f..17b1646 100644
>  Gr?gory> +--- a/elf32-littlearm.lds
>  Gr?gory> ++++ b/elf32-littlearm.lds
>  Gr?gory> +@@ -10,11 +10,21 @@ SECTIONS
>  Gr?gory> + 		*(.rodata)                 /* read-only data (constants) */
>  Gr?gory> + 		*(.rodata*)
>  Gr?gory> + 		. = ALIGN(4);
>  Gr?gory> ++		*(.glue_7)
>  Gr?gory> ++		. = ALIGN(4);
>  Gr?gory> ++		*(.eh_frame)
>  Gr?gory> ++		. = ALIGN(4);
> 
> Is all of that needed? Isn't it just that gcc 4.6+ adds a bunch of
> .text.<blah> sections? I've fixed it up for an internal tree at work by
> just doing:
> 
> diff --git a/elf32-littlearm.lds b/elf32-littlearm.lds
> index a33952f..f50c30c 100644
> --- a/elf32-littlearm.lds
> +++ b/elf32-littlearm.lds
> @@ -6,7 +6,7 @@ SECTIONS
>          . = ALIGN(4);
>         .text : { 
>                 _stext = .;
> -               *(.text)
> +               *(.text*)
>                 *(.rodata)                 /* read-only data (constants) */
>                 *(.rodata*)
>                 . = ALIGN(4);
> 

  reply	other threads:[~2012-10-09 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02  6:57 [Buildroot] [PATCH] at91bootstrap: fix gcc-4.6.x overlap linker issue Grégory Hermant
2012-10-08 20:04 ` Peter Korsgaard
2012-10-09 16:37   ` Grégory Hermant [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-01 15:58 Grégory Hermant
2012-10-01 17:44 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507452D7.7010503@calao-systems.com \
    --to=gregory.hermant@calao-systems.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox