Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: have check_glibc to search deeper for ld-linux
Date: Sat, 13 Oct 2012 11:35:58 +0200	[thread overview]
Message-ID: <507935FE.4010500@mind.be> (raw)
In-Reply-To: <1350073550-779-1-git-send-email-jean-mickael.guerin@6wind.com>

On 12/10/12 22:25, Jean-Mickael Guerin wrote:
> ld-linux*.so may not be present in lib/ directory, it could be
> in lib32 and/or lib64 only. But check_glibc reports
> "Incorrect selection of the C library" in this case, which is
> not true.
> Fixed by extending the search to  SYSROOT/*/*.
>
> Signed-off-by: Jean-Mickael Guerin<jean-mickael.guerin@6wind.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   toolchain/helpers.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index d5ab91b..497cfff 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -196,7 +196,7 @@ check_glibc_feature = \
>   #
>   check_glibc = \
>   	SYSROOT_DIR="$(strip $1)"; \
> -	if test `find $${SYSROOT_DIR}/lib/ -maxdepth 1 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
> +	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \

  Maybe it's better to search in /lib*/ ?  Not that it really matters that much.

  Regards,
  Arnout

>   		echo "Incorrect selection of the C library"; \
>   		exit -1; \
>   	fi; \

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-10-13  9:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 20:25 [Buildroot] [PATCH] toolchain: have check_glibc to search deeper for ld-linux Jean-Mickael Guerin
2012-10-13  9:35 ` Arnout Vandecappelle [this message]
2012-10-20 19:06 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507935FE.4010500@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox