Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] beecrypt: enable OpenMP if Buildroot GCC supports it
Date: Sat, 13 Oct 2012 16:25:46 +0300	[thread overview]
Message-ID: <50796BDA.3040008@petroprogram.com> (raw)
In-Reply-To: <50793478.1090305@mind.be>

13.10.2012 12:29, Arnout Vandecappelle kirjoitti:
> On 12/10/12 21:54, Stefan Fr?berg wrote:
>>
>> Signed-off-by: Stefan Fr?berg<stefan.froberg@petroprogram.com>
>> ---
>>   package/beecrypt/beecrypt.mk |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/beecrypt/beecrypt.mk b/package/beecrypt/beecrypt.mk
>> index d165aee..101d0df 100644
>> --- a/package/beecrypt/beecrypt.mk
>> +++ b/package/beecrypt/beecrypt.mk
>> @@ -18,6 +18,12 @@ BEECRYPT_CONF_OPT = \
>>           --without-java \
>>           --without-python
>>
>> +ifeq ($(BR2_GCC_ENABLE_OPENMP),y)
>> +BEECRYPT_CONF_OPT += --enable-openmp
>> +else
>> +BEECRYPT_CONF_OPT += --disable-openmp
>> +endif
>> +
>
>  This doesn't solve the underlying issue that -lgomp isn't included.  In
> addition, it would only enable openmp for internal toolchains, while
> it may
> be present for ct-ng or external toolchains as well.  I think the
> automatic
> detection works well in this case.
>

Yeah, but how do you test the presence of OpenMP in case of external
toolchain ?
Checking if /usr/lib/libgomp.so.* are present ?
Parsing the output of external toolchain "gcc -v" ? (there is not even
configure switch for OpenMP in current gcc)

There are just too many variables and corner cases when it comes for
testing various features of buildroot external toolchains.

And the automatic detection didn't work for Alexander and he was even
using the internal toolchain
(if Im not wrong he uses ARM version of internal buildroot toolchain ?)


Best regards
Stefan
>  Regards,
>  Arnout

  reply	other threads:[~2012-10-13 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 19:54 [Buildroot] [PATCH] beecrypt: enable OpenMP if Buildroot GCC supports it Stefan Fröberg
2012-10-13  9:29 ` Arnout Vandecappelle
2012-10-13 13:25   ` Stefan Fröberg [this message]
2012-10-13 13:29     ` Arnout Vandecappelle
2012-10-13 14:07       ` Stefan Fröberg
2012-10-13 14:54         ` Alexander Khryukin
2012-10-13 15:07           ` Stefan Fröberg
2012-10-13 20:56           ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50796BDA.3040008@petroprogram.com \
    --to=stefan.froberg@petroprogram.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox