Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] Split target/Config.in.arch into multiple Config.in.* in arch/
Date: Sat, 03 Nov 2012 19:28:35 +0100	[thread overview]
Message-ID: <50956253.9040800@mind.be> (raw)
In-Reply-To: <082538b6f5188dba251aac377ebf29560b1c5606.1348468443.git.thomas.petazzoni@free-electrons.com>

On 09/24/12 08:34, Thomas Petazzoni wrote:
> target/Config.in.arch had become too long, and we want to remove the
> target/ directory. So let's move it to arch/ and split it this way:
>
>   * An initial Config.in that lists the top-level architecture, and
>     sources the arch-specific Config.in.<arch>  files, as well as
>     Config.in.common (see below)
>
>   * One Config.in.<arch>  per architecture, listing the CPU families,
>     ABI choices, etc.
>
>   * One Config.in.common that defines the gcc mtune, march, mcpu values
>     and other hidden options.
>
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>

  Checked by sorting everything and taking the diff with the original, which
brings me to:

[snip]
> +config BR2_mips64el
> +       bool "MIPS64 (little endian)"
> +       select BR2_ARCH_IS_64
> +       help
> +         MIPS is a RISC microprocessor from MIPS Technologies. Big endian.

  Not Big endian... But it was like that already in the original.

  Also you're using spaces here I think.

[snip]
> +config BR2_mips_3
> +	bool "mips III"
> +	depends on !BR2_ARCH_IS_64

  This 'depends on !BR2_ARCH_IS_64' wasn't present in the original...

  Regards,
  Arnout

[snip]
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-11-03 18:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  6:34 [Buildroot] [pull request v2] Pull request for branch remove-target-dir Thomas Petazzoni
2012-09-24  6:34 ` [Buildroot] [PATCH 1/3] New top-level directory: system Thomas Petazzoni
2012-09-24 20:09   ` Yann E. MORIN
2012-09-24 20:28     ` Yann E. MORIN
2012-10-14 16:01   ` Arnout Vandecappelle
2012-09-24  6:34 ` [Buildroot] [PATCH 2/3] Split target/Config.in.arch into multiple Config.in.* in arch/ Thomas Petazzoni
2012-11-03 18:28   ` Arnout Vandecappelle [this message]
2012-09-24  6:34 ` [Buildroot] [PATCH 3/3] arch: improve definition of gcc mtune, mcpu, etc Thomas Petazzoni
2012-09-24 17:02   ` Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2012-11-03 18:27 [Buildroot] [pull request] Pull request for branch remove-target-dir Thomas Petazzoni
2012-11-03 18:27 ` [Buildroot] [PATCH 2/3] Split target/Config.in.arch into multiple Config.in.* in arch/ Thomas Petazzoni
2012-11-04 11:52   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50956253.9040800@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox