From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lua: remove shared library feature
Date: Sun, 04 Nov 2012 20:02:34 +0100 [thread overview]
Message-ID: <5096BBCA.9010707@mind.be> (raw)
In-Reply-To: <CAGhdn56HngpQGgFX4ax3cbGO23yXN7WWto35yYDneUODpcO0Pg@mail.gmail.com>
On 11/04/12 15:24, Fran?ois Perrad wrote:
> 2012/11/4 Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>:
>> > The shared library is a feature we added to lua, but it doesn't work
>> > correctly. Since we anyway normally don't add features to packages,
>> > just remove all the support for the shared library.
>> >
>> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
>> > ---
>> > Francois, Gustavo, could you review and Ack this patch please? You're
>> > more or less the lua maintainers...
> NACK, for this patch.
>
> The problem is the option BR2_PACKAGE_LUA_SHARED_LIBRARY,
> not the added feature of shared library.
> See my patches serie (2012 Sep 4) :
> [4/5] lua: remove 3 sub-options, always install all
> (http://patchwork.ozlabs.org/patch/181504/)
> [5/5] lua: refactor without useless define's
> (http://patchwork.ozlabs.org/patch/181505/)
>
> note: these 2 last patches could be applied without the 3 first.
OK, thanks for the reminder, and sorry it took so long to accept them.
FYI we decided to accept patches more aggressively in the future, so it
will hopefully not take such a long time anymore.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-11-04 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 12:43 [Buildroot] [PATCH] lua: remove shared library feature Arnout Vandecappelle
2012-11-04 14:24 ` François Perrad
2012-11-04 19:02 ` Arnout Vandecappelle [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-04 12:45 Arnout Vandecappelle
2013-08-13 22:36 ` Thomas Petazzoni
2013-08-15 16:56 ` François Perrad
2013-08-15 17:07 ` Thomas Petazzoni
2013-08-15 21:51 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5096BBCA.9010707@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox