From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add new package fxload
Date: Wed, 07 Nov 2012 01:23:07 +0100 [thread overview]
Message-ID: <5099A9EB.4070200@mind.be> (raw)
In-Reply-To: <1352199012-7746-1-git-send-email-jeremy.rosen@openwide.fr>
On 06/11/12 11:50, J?r?my Rosen wrote:
> Signed-off-by: J?r?my Rosen<jeremy.rosen@openwide.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v2: Incorporated comments from Arnout,
Yep, this is the way to separate additional comments from the commit message.
>
> I am not sure about the make install target line,
>
> I would have expected prefix= to be set by the environement, but maybe it is not a standard var name for make...
Nope. The usual variable is DESTDIR. I guess in fxload they have chosen prefix
because it's similar to 'configure --prefix'.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-11-07 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 10:50 [Buildroot] [PATCH] add new package fxload Jérémy Rosen
2012-11-07 0:23 ` Arnout Vandecappelle [this message]
2012-11-07 9:49 ` Peter Korsgaard
2012-11-07 10:00 ` Jeremy Rosen
[not found] <1781554.153.1352137532474.JavaMail.rosen@pcrosen>
2012-11-05 17:48 ` Jeremy Rosen
2012-11-06 0:01 ` Arnout Vandecappelle
2012-11-06 8:58 ` Jeremy Rosen
2012-11-06 15:33 ` Alex Bradbury
2012-11-07 0:21 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5099A9EB.4070200@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox