From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/11] nfs-utils: reformat patch set as git patches
Date: Mon, 12 Nov 2012 00:24:06 +0100 [thread overview]
Message-ID: <50A03396.9050403@mind.be> (raw)
In-Reply-To: <d86142f877a476239ab6c3cf49f09cebb6f285f6.1352583641.git.thomas.petazzoni@free-electrons.com>
On 11/10/12 22:42, Thomas Petazzoni wrote:
> As we will need to add more patches to nfs-utils, we need a correct
> ordering when applying patches. Therefore, reformat the patches to use
> a git format and git naming.
>
> The nfs-utils-dont-mix-flags.patch is no longer needed as it was
> patching Makefile.in files that were being regenerated due to the
> package having _AUTORECONF = YES. The Makefile.in are properly
> regenerated thanks to the nfs-utils-0002-Patch-taken-from-Gentoo.patch
> patch.
>
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
[snip]
> diff --git a/package/nfs-utils/nfs-utils-cross-build.patch b/package/nfs-utils/nfs-utils-0002-Patch-taken-from-Gentoo.patch
> similarity index 69%
> rename from package/nfs-utils/nfs-utils-cross-build.patch
> rename to package/nfs-utils/nfs-utils-0002-Patch-taken-from-Gentoo.patch
> index 43928bf..e310c49 100644
> --- a/package/nfs-utils/nfs-utils-cross-build.patch
> +++ b/package/nfs-utils/nfs-utils-0002-Patch-taken-from-Gentoo.patch
> @@ -1,7 +1,17 @@
> -Patch taken from Gentoo.
> +From 971389625c9602085d399d8ae7fc42b75efcfb7c Mon Sep 17 00:00:00 2001
> +From: Gustavo Zacarias<gustavo@zacarias.com.ar>
> +Date: Sat, 10 Nov 2012 18:56:12 +0100
> +Subject: [PATCH] Patch taken from Gentoo
Could you take the opportunity to improve the patch description a bit?
[snip]
> diff --git a/package/nfs-utils/nfs-utils-susv3-legacy.patch b/package/nfs-utils/nfs-utils-0003-Switch-legacy-index-in-favour-of-strchr.patch
> similarity index 50%
> rename from package/nfs-utils/nfs-utils-susv3-legacy.patch
> rename to package/nfs-utils/nfs-utils-0003-Switch-legacy-index-in-favour-of-strchr.patch
> index 66dd181..82a6c43 100644
> --- a/package/nfs-utils/nfs-utils-susv3-legacy.patch
> +++ b/package/nfs-utils/nfs-utils-0003-Switch-legacy-index-in-favour-of-strchr.patch
> @@ -1,11 +1,20 @@
> -Switch legacy index() in favour of strchr()
> -Updated for 1.2.6 from the previous patch by Frederik Pasch.
> +From 636e78e4c9bc8be174805bde2f3ae7f940dc3d0e Mon Sep 17 00:00:00 2001
> +From: Gustavo Zacarias<gustavo@zacarias.com.ar>
> +Date: Sat, 10 Nov 2012 18:58:15 +0100
> +Subject: [PATCH] Switch legacy index() in favour of strchr() Updated for
> + 1.2.6 from the previous patch by Frederik Pasch.
There should be an extra newline here.
[snip]
> +--
> +1.7.9.5
> +
Minor nit: this git version number is also something that is in the way for
refreshing patches. I posted a script a while ago to generate patches from
git, and it strips those lines from the patches.
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-11-11 23:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 21:42 [Buildroot] Fixes for RPC support Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 01/11] conntrack-tools: do not depend on BR2_INET_RPC and use libtirpc when available Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 02/11] libtirpc: remove patch numbers from patch titles Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 03/11] libtirpc: add patches to fix a number of issues Thomas Petazzoni
2012-11-13 6:47 ` Arnout Vandecappelle
2012-11-10 21:42 ` [Buildroot] [PATCH 04/11] libtirpc: handle the case where uClibc may have RPC support Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 05/11] nfs-utils: reformat patch set as git patches Thomas Petazzoni
2012-11-11 23:24 ` Arnout Vandecappelle [this message]
2012-11-10 21:42 ` [Buildroot] [PATCH 06/11] nfs-utils: add patches to allow compilation against libtirpc Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 07/11] quota: allow usage of getrpcbynumber() instead of getrpcbynumber_r() Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 08/11] rpcbind: convert to git patch Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 09/11] rpcbind: allow build without NSS support Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 10/11] libnetfilter_queue: does not build without IPv6 support Thomas Petazzoni
2012-11-10 21:42 ` [Buildroot] [PATCH 11/11] rpcbind: fix build on toolchains " Thomas Petazzoni
2012-11-14 22:02 ` [Buildroot] Fixes for RPC support Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A03396.9050403@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox