From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] PATCH > To integrate pycrypto into Buildroot
Date: Wed, 28 Nov 2012 22:12:52 +0100 [thread overview]
Message-ID: <50B67E54.4060006@mind.be> (raw)
In-Reply-To: <07407110F438184D9D87521726FF42D41F64FE15@M357PRD1.ad.bcc.qld.gov.au>
On 28/11/12 06:05, Noel Roberts wrote:
> This patch allows Buildroot to cross compile the crypto libraries needed for python integration, enabling good
> cryptographic support within Python.
>
> This is my first patch submission - please advise me, if I need to rework anything.
We prefer patches to be sent in-line (with git send-email) because then it is
easier to comment on them. But I'll already give some feedback before you re-post.
- If you include it in package/Config.in's 'external python modules' menu,
then the 'depends on BR2_PACKAGE_PYTHON' is redundant.
- Please add the license information:
PYTHON_CRYPTO_LICENSE = Public domain, Python 2.2 license
PYTHON_CRYPTO_LICENSE_FILES = COPYRIGHT LEGAL/copy/LICENSE.python-2.2
- Since there is a check for wchar.h in configure.ac, I would add an
explicit 'depends on BR2_USE_WCHAR', even though python itself already
depends on it. But who knows, maybe that will ever be removed.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-11-28 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 5:05 [Buildroot] PATCH > To integrate pycrypto into Buildroot Noel Roberts
2012-11-28 13:02 ` Thomas Petazzoni
2012-11-28 21:12 ` Arnout Vandecappelle [this message]
2012-11-30 2:27 ` Noel Roberts
2012-11-30 5:21 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B67E54.4060006@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox