From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/next] package: add gd package
Date: Wed, 28 Nov 2012 23:09:55 +0100 [thread overview]
Message-ID: <50B68BB3.9090503@mind.be> (raw)
In-Reply-To: <20121128011244.B677B8F461@busybox.osuosl.org>
On 27/11/12 20:21, Peter Korsgaard wrote:
[snip]
> +# configure.ac has newer timestamp than aclocal.m4 / configure, so we need
> +# to autoreconf to regenerate them (or set configure.ac timestamp to older
> +# than them) to make the Makefile happy.
> +# configure.ac refers to AM_ICONV which we only have if gettext is enabled,
> +# so add a dummy definition elsewise
> +define GD_FIXUP_ICONV
> + echo 'm4_ifndef([AM_ICONV],[m4_define([AM_ICONV],[:])])' \
> + >> $(@D)/acinclude.m4
> +endef
> +
> +GD_PRE_CONFIGURE_HOOKS += GD_FIXUP_ICONV
Is there any reason why this is a pre-configure hook instead of a
post-patch hook?
The reason I ask is because I am thinking about putting the _patched_
source in the tarballs created by legal-info. That would imply doing
a <pkg>-dirclean followed by a <pkg>-patch, but if there is any patching
that is done in one of the later steps, it will be missed.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-11-28 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 19:21 [Buildroot] [git commit branch/next] package: add gd package Peter Korsgaard
2012-11-28 5:26 ` Baruch Siach
2012-11-28 13:06 ` Thomas Petazzoni
2012-11-28 14:09 ` Peter Korsgaard
2012-11-28 14:12 ` Baruch Siach
2012-11-28 22:09 ` Arnout Vandecappelle [this message]
2012-11-28 22:28 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B68BB3.9090503@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox