From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-download.mk: fix multiple matches in shallow clone test
Date: Sun, 09 Dec 2012 16:12:02 +0100 [thread overview]
Message-ID: <50C4AA42.7020401@mind.be> (raw)
In-Reply-To: <1354847827-4902-1-git-send-email-danomimanchego123@gmail.com>
On 07/12/12 03:37, Danomi Manchego wrote:
> Move the git reference directly to git-ls-remote rather than
> piping the output to grep, to help avoid reporting partial
> matches rather than the actual requested reference. Also,
> add quotes to protest "test" from failing when multiple
> strings are reported.
>
> Signed-off-by: Danomi Manchego<danomimanchego123@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/pkg-download.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index ea01b05..1705fcd 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -82,7 +82,7 @@ domainseparator=$(if $(1),$(1),/)
> define DOWNLOAD_GIT
> test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
> (pushd $(DL_DIR)> /dev/null&& \
> - ((test `git ls-remote $($(PKG)_SITE) | cut -f 2- | grep $($(PKG)_DL_VERSION)`&& \
> + ((test "`git ls-remote $($(PKG)_SITE) $($(PKG)_DL_VERSION)`"&& \
> echo "Doing shallow clone"&& \
> $(GIT) clone --depth 1 -b $($(PKG)_DL_VERSION) --bare $($(PKG)_SITE) $($(PKG)_BASE_NAME)) || \
> (echo "Doing full clone"&& \
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-12-09 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 2:37 [Buildroot] [PATCH] pkg-download.mk: fix multiple matches in shallow clone test Danomi Manchego
2012-12-09 15:12 ` Arnout Vandecappelle [this message]
2012-12-09 20:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C4AA42.7020401@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox