From: Viallard Anthony <viallard@syscom-instruments.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] gnuplot : new package
Date: Mon, 07 Jan 2013 17:02:52 +0100 [thread overview]
Message-ID: <50EAF1AC.8090907@syscom-instruments.com> (raw)
In-Reply-To: <20130107144800.29eb11ca@skate>
On 07. 01. 13 14:48, Thomas Petazzoni wrote:
> Dear Anthony Viallard,
>
> On Mon, 7 Jan 2013 14:30:13 +0100, Anthony Viallard wrote:
>
>> +GNUPLOT_INSTALL_TARGET = YES
> This line is not needed.
>
> Also, please make your 1/5, 2/5, 3/5 and the LICENSE part of 5/5 a
> single patch.
>
> And then, a second patch containing your 4/5 and and the part of 5/5
> that disables the documentation and the demos.
>
> There has already been some discussion with Stefan about how to split
> patches, and it seems that it is still not clear. Each patch should be
> a logical change that works on its own.
>
> So for example, in the same series, putting a package in section "Foo",
> and then moving it to section "Bar" is very strange. Since you can
> rebase your patches, why don't you put the package in section "Bar" in
> the first place, so that we can believe you did everything perfectly
> from the very beginning? :-)
>
> You don't need to show to the whole world the gazillions of steps you
> followed to create a package. You need to show the whole world a nice,
> clean set of commits, where each commit is a logical change, that keeps
> the "buildability" of Buildroot.
>
> Does that make sense?
>
> Thomas
Indeed,
Sorry, i knew my post is not very sexy. This is because my git
repository is very dirty and i don't known how clean my work.
I thoughwith lucky, my submit will be accepted :) Ok, i do the changes !
avd.
next prev parent reply other threads:[~2013-01-07 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 13:30 [Buildroot] [PATCH 1/5] gnuplot : new package Anthony Viallard
2013-01-07 13:30 ` [Buildroot] [PATCH 2/5] gnuplot : disable inadequate options for embedded platform Anthony Viallard
2013-01-07 13:30 ` [Buildroot] [PATCH 3/5] gnuplot : move under "Graphic applications" section Anthony Viallard
2013-01-07 13:30 ` [Buildroot] [PATCH 4/5] gnuplot : add --without-doc and --without-demo options Anthony Viallard
2013-01-07 13:30 ` [Buildroot] [PATCH 4/4] gnuplot : add LICENSE things and new configure options Anthony Viallard
2013-01-07 13:48 ` [Buildroot] [PATCH 1/5] gnuplot : new package Thomas Petazzoni
2013-01-07 16:02 ` Viallard Anthony [this message]
2013-01-07 16:10 ` Thomas Petazzoni
2013-01-08 8:57 ` Viallard Anthony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EAF1AC.8090907@syscom-instruments.com \
--to=viallard@syscom-instruments.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox