From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?U3RlZmFuIEZyw7ZiZXJn?= Date: Tue, 08 Jan 2013 00:23:33 +0200 Subject: [Buildroot] [PATCH] new variable _CONFIG_FIXUP In-Reply-To: <20130107231037.39a798cf@skate> References: <1357596078-7762-1-git-send-email-stefan.froberg@petroprogram.com> <1357596078-7762-2-git-send-email-stefan.froberg@petroprogram.com> <20130107231037.39a798cf@skate> Message-ID: <50EB4AE5.7070407@petroprogram.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Thomas 8.1.2013 0:10, Thomas Petazzoni kirjoitti: > Dear Stefan Fr?berg, > > On Tue, 8 Jan 2013 00:01:18 +0200, Stefan Fr?berg wrote: >> Signed-off-by: Stefan Fr?berg > Please add more details to your commit log. I.e, basically, most of your > introduction e-mail contents should go here. Okay > Remember: the contents of your introduction e-mail are not preserved in > the Git history. On the opposite, the commit log is preserved forever > in the Git history, so we want the details to be here. > >> --- >> package/pkg-generic.mk | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk >> index a570ad7..a410ad1 100644 >> --- a/package/pkg-generic.mk >> +++ b/package/pkg-generic.mk >> @@ -121,6 +121,14 @@ $(BUILD_DIR)/%/.stamp_staging_installed: >> @$(call MESSAGE,"Installing to staging directory") >> $($(PKG)_INSTALL_STAGING_CMDS) >> $(foreach hook,$($(PKG)_POST_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep)) >> + @$(call MESSAGE,"Fixing package configuration files") > Please show the message only if there are actually files to fixup. Or > maybe just don't display any message at all. Fixing those files is kind > of a detail. You mean checking first in if-statement if $($(PKG)_CONFIG_FIXUP exist ? What is the best way to detect if it exist ? >> + for file in $($(PKG)_CONFIG_FIXUP); do \ >> + if [ -e $(STAGING_DIR)/usr/bin/$${file} ]; then \ > No, we should not silently error out if the file doesn't exist, because > it's hiding a mistake of package .mk file. Instead, if the file doesn't > exist, we should loudly error out. Okay > Also, please include an update to the Buildroot manual, either as part > of this patch, or as a separate patch. Oh my, I really suck when doing any documentation stuff. But ill try..... > Thanks for your work! > > Thomas Thank you! Stefan