From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Date: Thu, 10 Jan 2013 11:24:33 +0100 Subject: [Buildroot] [PATCH 2/2] Adding media-ctl as a package In-Reply-To: <20130109170239.56a4e727@skate> References: <1357734594-8211-1-git-send-email-kpa_info@yahoo.fr> <1357734594-8211-2-git-send-email-kpa_info@yahoo.fr> <20130109170239.56a4e727@skate> Message-ID: <50EE96E1.70308@yahoo.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 01/09/2013 05:02 PM, Thomas Petazzoni wrote: > Dear kpa_info at yahoo.fr, > > On Wed, 9 Jan 2013 13:29:54 +0100, kpa_info at yahoo.fr wrote: >> +config BR2_PACKAGE_MEDIA_CTL >> + bool "media-ctl" >> + help >> + Media controller control application > > One empty newline + upstream URL of the project (even if it's just a > http link to the Git repository). And also the description seems a bit > short, since it does not only contains an application, but also a > library, no? > >> diff --git a/package/media-ctl/media-ctl.mk >> b/package/media-ctl/media-ctl.mk new file mode 100644 >> index 0000000..3c35278 >> --- /dev/null >> +++ b/package/media-ctl/media-ctl.mk >> @@ -0,0 +1,18 @@ >> +############################################################# >> +# >> +# media-ctl >> +# >> +############################################################# >> + >> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7 >> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git >> +MEDIA_CTL_INSTALL_STAGING = YES >> +MEDIA_CTL_LICENSE = GPLv2 > > The license is LGPLv2.1+. > >> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB >> + >> +MEDIA_CTL_AUTORECONF = YES >> +MEDIA_CTL_AUTORECONF_OPT = --install > > Are you sure this AUTORECONF_OPT is needed? If so, then please add a > comment before this line that explains why. > >> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include >> +MEDIA_CTL_DEPENDENCIES = host-pkgconf >> + >> +$(eval $(autotools-package)) > > Otherwise, looks good, thanks! > > Thomas > Dear Thomas, Please find below the new version of the patch according to your comments. Patrick From: Patrick Gerber Signed-off-by: Patrick Gerber --- package/Config.in | 1 + package/media-ctl/Config.in | 4 ++++ package/media-ctl/media-ctl.mk | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100644 package/media-ctl/Config.in create mode 100644 package/media-ctl/media-ctl.mk diff --git a/package/Config.in b/package/Config.in index bd1db6b..2f3b601 100644 --- a/package/Config.in +++ b/package/Config.in @@ -245,6 +245,7 @@ source "package/lshw/Config.in" source "package/lsuio/Config.in" source "package/lvm2/Config.in" source "package/mdadm/Config.in" +source "package/media-ctl/Config.in" source "package/memtester/Config.in" source "package/minicom/Config.in" source "package/nanocom/Config.in" diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in new file mode 100644 index 0000000..9fb888c --- /dev/null +++ b/package/media-ctl/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_MEDIA_CTL + bool "media-ctl" + help + Media controller control application + + http://git.ideasonboard.org/media-ctl.git diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk new file mode 100644 index 0000000..3c35278 --- /dev/null +++ b/package/media-ctl/media-ctl.mk @@ -0,0 +1,17 @@ +############################################################# +# +# media-ctl +# +############################################################# + +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7 +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git +MEDIA_CTL_INSTALL_STAGING = YES +MEDIA_CTL_LICENSE = LGPLv2.1+ +MEDIA_CTL_LICENSE_FILES = COPYING.LIB + +MEDIA_CTL_AUTORECONF = YES +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include +MEDIA_CTL_DEPENDENCIES = host-pkgconf + +$(eval $(autotools-package)) -- 1.7.9.5