Re: [Buildroot] [PATCH v3 1/4] package/{python-}protobuf: bump to version 28.1

From: Michael Nosthoff via buildroot <buildroot@buildroot.org>
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>,
	Kamel Bouhara <kamel.bouhara@gmail.com>,
	buildroot@buildroot.org,
	Marcin Niestroj <m.niestroj@grinn-global.com>,
	Asaf Kahlon <asafka7@gmail.com>, Julien Olivain <ju.o@free.fr>,
	Woodrow Douglass <wdouglass@carnegierobotics.com>,
	Christian Stewart <christian@aperture.us>,
	Robert Rose <robertroyrose@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot]  [PATCH v3 1/4] package/{python-}protobuf: bump to version 28.1
Date: Mon, 28 Oct 2024 21:35:08 +0100	[thread overview]
Message-ID: <5109d-671ff580-3-4946930@44461145> (raw)
In-Reply-To: <20241028025410.62158-1-james.hilliard1@gmail.com>

Hi James,

On Monday, October 28, 2024 03:54 CET, James Hilliard <james.hilliard1@gmail.com> wrote:

> Migrate protobuf build from autotools to cmake.
> 
> Migrate protobuf-python to use pypi sources which are now required
> for setup.py builds:
> https://github.com/protocolbuffers/protobuf/tree/v28.1/python#building-from-setuppy
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---

with this series I can now build protobuf-c successfully.

The packages I now see issues with are mosh and collectd.

For mosh the error message is:

 119 | static_assert(PROTOBUF_CPLUSPLUS_MIN(201402L), "Protobuf only supports C++14 and newer.");

this is already addressed upstream: https://github.com/mobile-shell/mosh/commit/eee1a8cf413051c2a9104e8158e699028ff56b26
So we could cherry pick this patch (which raises the required C++ Version to 17) or could alter the package to build in C++14 mode...

For collectd it does find grpc but for some reason fails to find the correct protoc version:

checking for protobuf... yes
checking for main in -lprotobuf... yes
checking for google/protobuf/util/time_util.h... yes
checking for protoc... /build/buildroot/output/host/bin/protoc
checking for protoc 3.0.0+... no (libprotoc 28.1)
checking for libprotobuf-c... yes
checking for protobuf_c_message_pack in -lprotobuf-c... yes
checking for protobuf-c/protobuf-c.h... yes
checking for protoc-c... /build/buildroot/output/host/bin/protoc-c
....
grpc  . . . . . . . . no (protoc3 not found) (dependency error)

not sure what is going wrong there.

this is what I found in a short compile test...

used defconfig:

BR2_arm=y
BR2_cortex_a15=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_OLA=y
BR2_PACKAGE_USBGUARD=y
BR2_PACKAGE_COLLECTD=y
BR2_PACKAGE_COLLECTD_GRPC=y
BR2_PACKAGE_KISMET=y
BR2_PACKAGE_MOSH=y
BR2_PACKAGE_CRIU=y

Regards,
Michael

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot