[Buildroot] [PATCH] aircrack-ng: new package

[Stephan Hoffmann <sho@relinux.de>]

Am 08.02.2013 16:32, schrieb Thomas Petazzoni:
> Dear Laurent Cans,
>
> Thanks, this looks pretty good; A few comments below.
>
> On Fri,  8 Feb 2013 17:16:29 +0100, Laurent Cans wrote:
>> Aircrack-ng is a set of tools for auditing wireless security.
>>
>> Although the last version is 1.1, I choose to package last svn version due to a fixed bug which fix a failed compilation.
> Please wrap lines at ~80 columns.
>
>> diff --git a/package/aircrack-ng/Config.in b/package/aircrack-ng/Config.in
>> new file mode 100644
>> index 0000000..1efa8e6
>> --- /dev/null
>> +++ b/package/aircrack-ng/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_AIRCRACK_NG
>> +	bool "aircrack-ng"
>> +	depends on BR2_LARGEFILE
>> +	select BR2_PACKAGE_OPENSSL
>> +	select BR2_PACKAGE_WI
>> +	help
>> +	  A set of tools for auditing wireless networks
>> +
>> +	  http://www.aircrack-ng.org/
> Since your package depends on BR2_LARGEFILE, you must add a comment:
>
> comment "aircrack-ng needs a toolchain with largefile support"
> 	depends on !BR2_LARGEFILE
>
> Like we do for all other packages.
>
>> diff --git a/package/aircrack-ng/aircrack-ng.mk b/package/aircrack-ng/aircrack-ng.mk
>> new file mode 100644
>> index 0000000..29f638c
>> --- /dev/null
>> +++ b/package/aircrack-ng/aircrack-ng.mk
>> @@ -0,0 +1,34 @@
>> +#############################################################
>> +#
>> +# Aircrack-ng
>> +#
>> +#############################################################
>> +AIRCRACK_NG_VERSION = 2245
> One empty line between the header and the first variable definition.
Someone should fix this in the manual. I'll do this and provide a patch.

Regards

Stephan
>
>> +AIRCRACK_NG_SITE = http://trac.aircrack-ng.org/svn/trunk
>> +AIRCRACK_NG_SITE_METHOD = svn
>> +AIRCRACK_NG_LICENSE = GPLv2
> License is GPLv2+
>
>> +AIRCRACK_NG_LICENSE_FILES = LICENSE
>> +AIRCRACK_NG_DEPENDENCIES = openssl
>> +
>> +ifeq($(BR2_PACKAGE_SQLITE),y)
>> +      AIRCRACK_NG_OPTS = sqlite=true
>> +      AIRCRACK_NG_DEPENDENCIES += sqlite
>> +endif
> The src/Makefile contains:
>
> ifeq ($(subst TRUE,true,$(filter TRUE true,$(sqlite) $(SQLITE))),true)
> 	LIBSQL		= -L/usr/local/lib -lsqlite3
> else
> 	LIBSQL		=
> endif
>
> This -L/usr/local/lib isn't really nice since this is not where sqlite
> will be installed, and it may cause issues when cross-compiling.
>
>> +
>> +define AIRCRACK_NG_BUILD_CMDS
>> +      $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) $(AIRCRACK_NG_OPTS) all
>> +endef
> Use $(TARGET_CONFIGURE_OPTS) :
>
> 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) $(AIRCRACK_NG_OPTS) all
>
> And ditto for the other commands.
>
> Best regards,
>
> Thomas


-- 
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de