Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] question about my pevious dhcpcd patch
Date: Wed, 13 Mar 2013 21:46:00 +0100	[thread overview]
Message-ID: <5140E588.8070208@mind.be> (raw)
In-Reply-To: <1363199449.8204.157.camel@genx.eng.msli.com>

On 03/13/13 19:30, John Stile wrote:
> I have an update to my patch to add dhcpd.
>
> First issue: I discovered I also need to copy a script directory, but
> don't see a good method to copy more than each file one at a time.
>
> Is there a good way to copy all files in dhcpcd-hooks except the
> Makefile, into $(TARGET_DIR)/libexec/dhcpcd-hooks?
>
> Right now I'm doing it one at a time like this:
> 	$(INSTALL) -D -m 0755 \
> 		$(@D)/dhcpcd-hooks/01-test \
> 		$(TARGET_DIR)/libexec/dhcpcd-hooks/01-test
> 	$(INSTALL) -D -m 0755 \
> 		$(@D)/dhcpcd-hooks/02-dump \
> 		$(TARGET_DIR)/libexec/dhcpcd-hooks/02-dump
> 	$(INSTALL) -D -m 0755 \
> 		$(@D)/dhcpcd-hooks/20-resolv.conf \
> 		$(TARGET_DIR)/libexec/dhcpcd-hooks/20-resolv.conf
> 	$(INSTALL) -D -m 0755 \
> 		$(@D)/dhcpcd-hooks/29-lookup-hostname \
> 		$(TARGET_DIR)/libexec/dhcpcd-hooks/29-lookup-hostname

  Just do
	mkdir -p $(TARGET_DIR)/libexec/dhcpcd-hooks
	cp $(@D)/dhcpcd-hooks/* $(TARGET_DIR)/libexec/dhcpcd-hooks

  If permissions of the original files are wrong, just add a chmod.

  By the way, we don't have a /libexec at the moment, but we do have a 
/usr/libexec. So I would put it there.

>    ...etc...
>
> Second issue:  how do I submit an updated patch?  The first one was
> submitted a few days ago.  Do i just do a fresh clone, and then try to
> add my stuff and submit via send-email, and pretend the first patch was
> never sent?

  Assuming your patch is in git, you can make more changes, and then 
update your patch with "git commit --amend". Then you can just use git 
send-email like before.

  If you have made other changes in the mean time, you can commit your 
changes and squash them with the patch with 'git rebase -i origin/master'

  Also make sure you update your git repository with 'git pull --rebase'

  Regards,
  Arnout



-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-03-13 20:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 18:30 [Buildroot] question about my pevious dhcpcd patch John Stile
2013-03-13 20:46 ` Arnout Vandecappelle [this message]
2013-03-14 18:42 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5140E588.8070208@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox