From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Tue, 2 Apr 2013 20:05:58 +0400 Subject: [Buildroot] [PATCH] vlc: new package Message-ID: <515B01E6.4060608@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 04/02/2013 09:08 AM, Bernd Kuhls wrote: > Hi, > > Alexey Brodkin > wrote in news:1363687526-8469-1-git-send-email-abrodkin-HKixBCOQz3hWk0Htik3J/w at public.gmane.org: > >> +ifeq ($(BR2_PACKAGE_AVCODEC),y) > > shouldn?t this be called BR2_PACKAGE_VLC_AVCODEC? > >> +ifeq ($(BR2_PACKAGE_LUA),y) > > and this BR2_PACKAGE_VLC_LUA? > > Regards, Bernd Hi Bernd, The idea is to check if "avcodec" and "lua" packages were selected in configuration utility (menuconfig/xconfig etc). Indeed we may rely on VLC's symbols BR2_PACKAGE_AVCODEC and BR2_PACKAGE_LUA that select BR2_PACKAGE_FFMPEG and BR2_PACKAGE_LUA accordingly. So initial proposal is to sort of double check if we do have "avcodec" and "lua" selected. Even though you believe it's better to check VLC's own symbols I may do a re-spin. -Alexey