From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] python-setuptools: forkbump and add workaround for shebang
Date: Tue, 16 Apr 2013 07:17:46 -0300 [thread overview]
Message-ID: <516D254A.4010707@zacarias.com.ar> (raw)
In-Reply-To: <516CEF3C.6070505@mind.be>
On 04/16/2013 03:27 AM, Arnout Vandecappelle wrote:
> Mixing tabs with spaces... Also a few other instances in the rest of
> this patch.
That's probably my vim settings doing something evil, i don't have a
special case for python, i'll fix it.
> I would add a comment here, e.g.
>
> # "distribute" is a fork of the unmaintained setuptools package. There
> # are plans to re-merge it into setuptools; if this happens, we can
> # switch back to http://pypi.python.org/packages/source/s/setuptools
Fair enough.
> Please split this long line. Also, maybe it's worth explaining why we
> want --single-version-externally-managed?
That's for the trick to work, when python builds an egg (zip file) in
the build phase not only are we wasting time doing double decompression
later on the target but we are also finishing up the package (kind of a
mini-install phase) into the egg.
That makes the trick fail (probably solvable by doing --execute in the
build itself, didn't try since it's not the way IMHO).
I'll add a note since it's required for other python packages that do
use setuptools/distribution.
V2 when Thomas confirms it solves his issues with lava-test, did it for
me in my tests.
Regards.
next prev parent reply other threads:[~2013-04-16 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 16:56 [Buildroot] [PATCH 1/3] python-setuptools: forkbump and add workaround for shebang Gustavo Zacarias
2013-04-13 16:56 ` [Buildroot] [PATCH 2/3] python-bottle: bump version and fix shebang Gustavo Zacarias
2013-05-06 7:34 ` Peter Korsgaard
2013-04-13 16:56 ` [Buildroot] [PATCH 3/3] python-serial: " Gustavo Zacarias
2013-05-06 7:35 ` Peter Korsgaard
2013-05-06 11:08 ` Gustavo Zacarias
2013-05-06 11:27 ` Peter Korsgaard
2013-04-16 6:27 ` [Buildroot] [PATCH 1/3] python-setuptools: forkbump and add workaround for shebang Arnout Vandecappelle
2013-04-16 10:17 ` Gustavo Zacarias [this message]
2013-05-06 7:34 ` Peter Korsgaard
2013-05-06 11:07 ` Gustavo Zacarias
2013-05-06 11:30 ` Peter Korsgaard
2013-05-06 11:34 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D254A.4010707@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox