Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] post-build: show each script filename before execution
Date: Fri, 26 Apr 2013 09:25:33 +0200	[thread overview]
Message-ID: <517A2BED.1010304@lucaceresoli.net> (raw)
In-Reply-To: <87zjwnadmz.fsf@dell.be.48ers.dk>

Peter Korsgaard wrote:
>>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:
>   Luca> This also simplifies code by removing the ifneq/endif clauses.
>   Luca> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>   Luca> ---
>   Luca>  Makefile |    4 +---
>   Luca>  1 file changed, 1 insertion(+), 3 deletions(-)
>
>   Luca> diff --git a/Makefile b/Makefile
>   Luca> index c95bb1e..75f0f0c 100644
>   Luca> --- a/Makefile
>   Luca> +++ b/Makefile
>   Luca> @@ -509,11 +509,9 @@ endif
>   Luca>  			$${dir}/ $(TARGET_DIR); \
>   Luca>  	done
>   
>   Luca> -ifneq ($(BR2_ROOTFS_POST_BUILD_SCRIPT),"")
>   Luca> -	@$(call MESSAGE,"Executing post-build script\(s\)")
>   Luca>  	@$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT)), \
>   Luca> +		$(call MESSAGE,"Executing  post-build script $(s)"); \
>   Luca>  		$(s) $(TARGET_DIR)$(sep))
>
> Double space after 'executing'. Committed with that fixed, thanks.

Ouch, thanks.

Luca

  reply	other threads:[~2013-04-26  7:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 16:50 [Buildroot] [PATCH v2 0/3] Cleanup post-* loops Luca Ceresoli
2013-04-08 16:50 ` [Buildroot] [PATCH v2 1/3] post-build: show each script filename before execution Luca Ceresoli
2013-04-16 21:49   ` Yann E. MORIN
2013-04-17 16:13   ` Arnout Vandecappelle
2013-04-18  7:14     ` Yann E. MORIN
2013-04-24 20:15   ` Peter Korsgaard
2013-04-26  7:25     ` Luca Ceresoli [this message]
2013-04-30 16:57   ` Arnout Vandecappelle
2013-04-30 20:31     ` Peter Korsgaard
2013-04-08 16:50 ` [Buildroot] [PATCH v2 2/3] post-image: " Luca Ceresoli
2013-04-16 21:50   ` Yann E. MORIN
2013-04-24 20:16   ` Peter Korsgaard
2013-04-30 16:58   ` Arnout Vandecappelle
2013-04-08 16:50 ` [Buildroot] [PATCH v2 3/3] rootfs-overlay: use a make foreach instead of a shell for Luca Ceresoli
2013-04-16 21:55   ` Yann E. MORIN
2013-04-30 16:59   ` Arnout Vandecappelle
2013-04-30 20:33     ` Peter Korsgaard
2013-05-02  7:30     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517A2BED.1010304@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox