From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] vlc: new package
Date: Fri, 26 Apr 2013 11:33:32 +0400 [thread overview]
Message-ID: <517A2DCC.9060708@synopsys.com> (raw)
In-Reply-To: <64pdjk.r2d.ln@ID-313208.user.individual.net>
On 04/02/2013 09:08 AM, Bernd Kuhls wrote:
> Hi,
>
> Alexey Brodkin <Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> wrote in
news:1363687526-8469-1-git-send-email-abrodkin-HKixBCOQz3hWk0Htik3J/w at public.gmane.org:
>
>> +ifeq ($(BR2_PACKAGE_AVCODEC),y)
>
> shouldn?t this be called BR2_PACKAGE_VLC_AVCODEC?
>
>> +ifeq ($(BR2_PACKAGE_LUA),y)
>
> and this BR2_PACKAGE_VLC_LUA?
>
> Regards, Bernd
Hi Bernd,
The idea is to check if "avcodec" and "lua" packages were selected in
configuration utility (menuconfig/xconfig etc).
Indeed we may rely on VLC's symbols BR2_PACKAGE_AVCODEC and
BR2_PACKAGE_LUA that select BR2_PACKAGE_FFMPEG and BR2_PACKAGE_LUA
accordingly.
So initial proposal is to sort of double check if we do have "avcodec"
and "lua" selected.
Even though you believe it's better to check VLC's own symbols I may do
a re-spin.
-Alexey
next prev parent reply other threads:[~2013-04-26 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 10:05 [Buildroot] [PATCH] vlc: new package Alexey Brodkin
2013-04-02 5:08 ` Bernd Kuhls
2013-04-26 7:33 ` Alexey Brodkin [this message]
2013-05-06 15:35 ` Alexey Brodkin
2014-02-04 9:40 ` Thomas Petazzoni
2014-02-04 9:55 ` Alexey Brodkin
-- strict thread matches above, loose matches on Subject: below --
2014-01-06 22:09 spdawson at gmail.com
2014-01-07 3:39 ` Baruch Siach
2014-01-07 11:17 ` Simon Dawson
2014-01-07 11:51 ` Baruch Siach
2014-01-07 11:52 ` Simon Dawson
2014-01-07 6:26 ` Thomas Petazzoni
2014-01-07 11:20 ` Simon Dawson
2013-04-02 16:05 Alexey Brodkin
2012-02-28 0:02 [Buildroot] [PATCH] vlc: New package Ismael Luceno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A2DCC.9060708@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox