Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches
Date: Wed, 22 May 2013 08:08:22 +0200	[thread overview]
Message-ID: <519C60D6.5040207@mind.be> (raw)
In-Reply-To: <1368905110-23303-1-git-send-email-gustavo@zacarias.com.ar>

On 18/05/13 21:25, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>   boot/mxs-bootlets/Config.in       | 9 +++++++++
>   boot/mxs-bootlets/mxs-bootlets.mk | 8 ++++++++
>   2 files changed, 17 insertions(+)
>
> diff --git a/boot/mxs-bootlets/Config.in b/boot/mxs-bootlets/Config.in
> index 2222ff6..9dc2d37 100644
> --- a/boot/mxs-bootlets/Config.in
> +++ b/boot/mxs-bootlets/Config.in
> @@ -37,6 +37,15 @@ config BR2_TARGET_MXS_BOOTLETS_CUSTOM_GIT_VERSION
>
>   endif
>
> +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_PATCH_DIR
> +	string "custom patch dir"
> +	help
> +	  If your board requires custom patches, add the path to the
> +	  directory containing the patches here. The patches must be
> +	  named mxs-bootlets-<something>.patch.
> +
> +	  Most users may leave this empty
> +

  Now that we have BR2_GLOBAL_PATCH_DIR, I would prefer to avoid adding 
config options like this... Admittedly, for bootloaders it is more likely 
that custom patches are needed than for any other package. But even so, 
the global patch dir is sufficient, it is quite useable, and it reduces 
complexity in the buildroot core.

  Regards,
  Arnout

>   choice
>   	prompt "Bootstream"
>   	help
> diff --git a/boot/mxs-bootlets/mxs-bootlets.mk b/boot/mxs-bootlets/mxs-bootlets.mk
> index f93ff81..6b18fcc 100644
> --- a/boot/mxs-bootlets/mxs-bootlets.mk
> +++ b/boot/mxs-bootlets/mxs-bootlets.mk
> @@ -4,6 +4,14 @@
>   #
>   #############################################################
>
> +ifneq ($(call qstrip,$(BR2_TARGET_MXS_BOOTLETS_CUSTOM_PATCH_DIR)),)
> +define MXS_BOOTLETS_APPLY_CUSTOM_PATCHES
> +	support/scripts/apply-patches.sh $(@D) $(BR2_TARGET_MXS_BOOTLETS_CUSTOM_PATCH_DIR) \
> +		mxs-bootlets-\*.patch
> +endef
> +MXS_BOOTLETS_POST_PATCH_HOOKS += MXS_BOOTLETS_APPLY_CUSTOM_PATCHES
> +endif
> +
>   ifeq ($(BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL),y)
>   	MXS_BOOTLETS_TARBALL = $(call qstrip,$(BR2_TARGET_MXS_BOOTLETS_CUSTOM_TARBALL_URL))
>   	MXS_BOOTLETS_SITE = $(patsubst %/,%,$(dir $(MXS_BOOTLETS_TARBALL)))
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2013-05-22  6:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-18 19:25 [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches Gustavo Zacarias
2013-05-18 19:25 ` [Buildroot] [PATCH 2/2] configs: add sample for olimex mx233 olinuxino Gustavo Zacarias
2013-05-22  6:08 ` Arnout Vandecappelle [this message]
2013-05-22  6:58   ` [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches Thomas Petazzoni
2013-05-22  7:01     ` Arnout Vandecappelle
2013-05-27 16:42       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519C60D6.5040207@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox