Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] freetype: fix includedir
Date: Thu, 13 Jun 2013 08:08:10 +0200	[thread overview]
Message-ID: <51B961CA.6080405@mind.be> (raw)
In-Reply-To: <1371094112-7523-1-git-send-email-gustavo@zacarias.com.ar>

On 13/06/13 05:28, Gustavo Zacarias wrote:
> Set includedir to point to staging because freetype-config and
> freetype2.pc otherwise point to /usr/include causing all kind of havoc
> because it expands configure --prefix now instead of using the
> .pc/-config one.

  I think this is the wrong fix.

  The FREETYPE_CONFIG_SCRIPTS approach doesn't work in this case because 
this script doesn't use ${prefix} in front of it's includedir. I think 
the better fix is to use a custom POST_INSTALL_STAGING_HOOK that sets 
SYSROOT=$(STAGING_DIR) at the beginning of the script.

  The .pc file should be handled by our modified pkg-config.

  Regards,
  Arnout

>
> Fixes:
> http://autobuild.buildroot.net/results/1c7/1c70ce0ff350623cc38baf4b8b61c8a7a8586aba/
> ...and many others.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>   package/freetype/freetype.mk | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk
> index 16f00fe..4ea678b 100644
> --- a/package/freetype/freetype.mk
> +++ b/package/freetype/freetype.mk
> @@ -9,6 +9,7 @@ FREETYPE_SOURCE = freetype-$(FREETYPE_VERSION).tar.bz2
>   FREETYPE_SITE = http://downloads.sourceforge.net/project/freetype/freetype2/$(FREETYPE_VERSION)
>   FREETYPE_INSTALL_STAGING = YES
>   FREETYPE_MAKE_OPT = CCexe="$(HOSTCC)"
> +FREETYPE_CONF_OPT = --includedir="$(STAGING_DIR)/usr/include"
>   FREETYPE_LICENSE = Dual FTL/GPLv2+
>   FREETYPE_LICENSE_FILES = docs/FTL.TXT docs/GPLv2.TXT
>   FREETYPE_DEPENDENCIES = host-pkgconf \
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-06-13  6:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  3:28 [Buildroot] [PATCH] freetype: fix includedir Gustavo Zacarias
2013-06-13  6:08 ` Arnout Vandecappelle [this message]
2013-06-13 10:28   ` Gustavo Zacarias
2013-06-13 12:25     ` Sagaert Johan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B961CA.6080405@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox