From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v2 1/1] ti-gfx: add new package
Date: Wed, 26 Jun 2013 21:50:48 +0200 [thread overview]
Message-ID: <51CB4618.5060603@mind.be> (raw)
In-Reply-To: <20130626125300.057a48ca@bourban>
On 26/06/13 19:53, Spenser Gilliland wrote:
>> In this particular case, I notice that Thomas repeats a lot of
>> >review comments that I've made a week ago, so writing "review
>> >comments from Arnout not taken into account" would have helped:-) Or
>> >maybe you missed those?
> Sorry about that, they were good comments but I was just trying to get
> it functional and most of the comments were cosmetic in nature. I'll
> get them all fixed up soon.
No, it's perfectly OK that you repost something without already taking
account all previously posted feedback. Just mention it in the patch
comments.
FYI in case you don't know, the commit message is ideally formatted as
follows:
----------------------------------------------------
ti-gfx: new package
Anything else that should go in the git history (usually nothing for new
packages).
Signed-off-by: You Know Who <ykw@buildroot.net>
---
Comments for the reviewers, e.g. "This is work in progress, this and that
is still to do."
v3: modified here and there
v2: changed such and such
-----------------------------------------------------
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-06-26 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:29 [Buildroot] [RFC v2 1/1] ti-gfx: add new package Spenser Gilliland
2013-06-25 20:31 ` Thomas Petazzoni
2013-06-26 17:52 ` Spenser Gilliland
2013-06-26 19:46 ` Thomas Petazzoni
2013-06-25 21:42 ` Arnout Vandecappelle
2013-06-25 22:51 ` Nicolas Dechesne
2013-06-26 2:36 ` Sundareson, Prabindh
2013-06-26 8:59 ` [Buildroot] About ti-gfx package Sinan Akpolat
2013-06-26 17:53 ` [Buildroot] [RFC v2 1/1] ti-gfx: add new package Spenser Gilliland
2013-06-26 19:50 ` Arnout Vandecappelle [this message]
2013-06-26 19:50 ` Thomas Petazzoni
2013-06-26 2:26 ` Sundareson, Prabindh
2013-06-26 18:02 ` Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB4618.5060603@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox