Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] jimtcl: new package
Date: Thu, 27 Jun 2013 17:02:18 -0300	[thread overview]
Message-ID: <51CC9A4A.9040206@zacarias.com.ar> (raw)
In-Reply-To: <1372252177-3592-1-git-send-email-elezegarcia@gmail.com>

On 06/26/2013 10:09 AM, Ezequiel Garcia wrote:

A few fixes...

> +JIMTCL_VERSION = 0.73
> +JIMTCL_SITE = git://repo.or.cz/jimtcl.git
> +JIMTCL_SITE_METHOD = git
> +JIMTCL_INSTALL_STAGING = YES

Why not use the debian mirror as i did?
It's usually nicer to do http since some paranoid firewalling in some
companies block git access.

> +ifneq ($(BR2_PACKAGE_TCL),y)
> +define JIMTCL_LINK_TCLSH
> +	ln -sf jimsh $(TARGET_DIR)/usr/bin/tclsh
> +endef
> +endif

Positive logic preferred...
ifeq ($(BR2_PACKAGE_TCL),)
...
(my fault from my old submission though).

Care to resend a V2?
Thanks.

  reply	other threads:[~2013-06-27 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 13:09 [Buildroot] [PATCH] jimtcl: new package Ezequiel Garcia
2013-06-27 20:02 ` Gustavo Zacarias [this message]
2013-06-27 20:07   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CC9A4A.9040206@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox