Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: richard.genoud at gmail.com <richard.genoud@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] tcl: change BR2_PACKAGE_TCL_SHLIB_ONLY option
Date: Fri, 21 Jun 2013 13:56:57 +0200	[thread overview]
Message-ID: <51c43f9c.ebbbb40a.0abf.ffffba07@mx.google.com> (raw)
In-Reply-To: <1371815822-29453-1-git-send-email-y>

From: Richard Genoud <richard.genoud@gmail.com>

It's not convenient to have an option (defaulted to yes) that removes a
software.
For instance, usb_modeswitching_data needs the tclsh interpreter, so it
would have to un-select this option, but select TCL.

Having an option that adds the tclsh binary (defaulted to no to keep the
same behaviour) is way more convenient.
Moreover, it seems that it was intended liked that at the begining
because usb_modeswitching_data already selects BR2_PACKAGE_TCL_TCLSH
which wasn't declared anywhere.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 package/tcl/Config.in |   11 +++++------
 package/tcl/tcl.mk    |    2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/package/tcl/Config.in b/package/tcl/Config.in
index 7a4d887..8af7980 100644
--- a/package/tcl/Config.in
+++ b/package/tcl/Config.in
@@ -16,12 +16,11 @@ config BR2_PACKAGE_TCL_DEL_ENCODINGS
 
 	  It saves approx. 1.4 Mb of space.
 
-config BR2_PACKAGE_TCL_SHLIB_ONLY
-	bool "install only shared library"
-	default y
+config BR2_PACKAGE_TCL_TCLSH
+	bool "Install also tclsh binary, not only the shared library"
+	default n
 	depends on BR2_PACKAGE_TCL
 	help
-	  Install only TCL shared library and not binary tcl
-	  interpreter(tclsh8.4).
+	  Install the TCL interpreter binary file(tclsh8.4).
 
-	  Saves ~14kb.
+	  Adds ~14kb.
diff --git a/package/tcl/tcl.mk b/package/tcl/tcl.mk
index 0c8fa33..ad23b80 100644
--- a/package/tcl/tcl.mk
+++ b/package/tcl/tcl.mk
@@ -27,7 +27,7 @@ define TCL_POST_INSTALL_CLEANUP
 	-if [ "$(BR2_PACKAGE_TCL_DEL_ENCODINGS)" = "y" ]; then \
 	rm -Rf $(TARGET_DIR)/usr/lib/tcl$(TCL_VERSION_MAJOR)/encoding/*; \
 	fi
-	-if [ "$(BR2_PACKAGE_TCL_SHLIB_ONLY)" = "y" ]; then \
+	-if [ "$(BR2_PACKAGE_TCL_TCLSH)" != "y" ]; then \
 	rm -f $(TARGET_DIR)/usr/bin/tclsh$(TCL_VERSION_MAJOR); \
 	fi
 endef
-- 
1.7.10.4

  parent reply	other threads:[~2013-06-21 11:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 15:53 [Buildroot] [PATCH 0/4] make usb_modeswitch work with udev Richard Genoud
2013-06-20 15:53 ` [Buildroot] [PATCH 1/4] TCL: change BR2_PACKAGE_TCL_SHLIB_ONLY option Richard Genoud
2013-06-20 15:59   ` Thomas Petazzoni
2013-06-20 15:53 ` [Buildroot] [PATCH 2/4] tcl: add a tclsh symlink Richard Genoud
2013-06-20 15:53 ` [Buildroot] [PATCH 3/4] usb_modeswitch: bump to 1.2.6 Richard Genoud
2013-06-20 16:00   ` Thomas Petazzoni
2013-06-20 17:02     ` Richard Genoud
2013-06-20 17:04       ` Gustavo Zacarias
2013-06-20 15:53 ` [Buildroot] [PATCH 4/4] usb_modeswitch_data: bump to 20130610 Richard Genoud
2013-06-21 11:56 ` [Buildroot] [PATCH 0/6] tcl rework (was: make usb_modeswitch work with udev) richard.genoud at gmail.com
     [not found] ` <1371815822-29453-1-git-send-email-y>
2013-06-21 11:56   ` richard.genoud at gmail.com [this message]
2013-06-22  9:15     ` [Buildroot] [PATCH 1/6] tcl: change BR2_PACKAGE_TCL_SHLIB_ONLY option Patrick Ziegler
2013-06-24  7:49       ` Richard Genoud
2013-06-21 11:56   ` [Buildroot] [PATCH 2/6] tcl: use make conditions richard.genoud at gmail.com
2013-06-21 11:56   ` [Buildroot] [PATCH 3/6] tcl: remove strip command richard.genoud at gmail.com
2013-06-21 11:57   ` [Buildroot] [PATCH 4/6] tcl: install the libtcl into staging richard.genoud at gmail.com
2013-06-21 11:57   ` [Buildroot] [PATCH 5/6] tcl: add a tclsh symlink richard.genoud at gmail.com
2013-06-21 11:57   ` [Buildroot] [PATCH 6/6] tcl: make the libtcl writable in order to be stripped richard.genoud at gmail.com
2013-06-24  8:40 ` [Buildroot] [PATCHv3 0/5] tcl rework (was: make usb_modeswitch work with udev) Richard Genoud
2013-06-24  8:40   ` [Buildroot] [PATCHv3 1/5] tcl: use make conditions Richard Genoud
2013-06-24  8:40   ` [Buildroot] [PATCHv3 2/5] tcl: remove strip command Richard Genoud
2013-06-24  8:40   ` [Buildroot] [PATCHv3 3/5] tcl: install the libtcl into staging Richard Genoud
2013-06-24  8:40   ` [Buildroot] [PATCHv3 4/5] tcl: add a tclsh symlink Richard Genoud
2013-06-24  8:40   ` [Buildroot] [PATCHv3 5/5] tcl: make the libtcl writable in order to be stripped Richard Genoud
2013-07-28 14:29   ` [Buildroot] [PATCHv3 0/5] tcl rework (was: make usb_modeswitch work with udev) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51c43f9c.ebbbb40a.0abf.ffffba07@mx.google.com \
    --to=richard.genoud@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox