From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: display current task as title of the term window
Date: Wed, 21 Aug 2013 00:32:15 +0200 [thread overview]
Message-ID: <5213EE6F.7040006@mind.be> (raw)
In-Reply-To: <CAAXf6LWzouV+VGEHJric3M3yt5zGmtg=iVmsUeKN5yk4JDE1Vw@mail.gmail.com>
On 19/08/13 20:49, Thomas De Schampheleire wrote:
[snip]
> >> However, while testing again, I noticed an annoyance: if the build
> >> process stops prematurely, for example because the build fails or the
> >> user interrupts it, the last tab title remains. I would much prefer
> >> that we can cleanly restore this no matter how buildroot/make stops.
> >
> >
> > Won't that be the case regardless of whether the build fails or succeeds?
>
> Currently it is indeed, but that could easily be fixed by adding an extra
> such print at the end.
A print of what? An empty string? Then your window won't have a title
anymore... There is no way to save the previous window title, so I really
think that if PS1 doesn't set the window title, then buildroot shouldn't
either.
Regards,
Arnout
>
> >
> > I think this patch is only really suitable for people who have
> something similar in their PS1. Otherwise it will just mess up your
> window title.
> >
> > Also, it should only be done if $TERM == xterm, otherwise you get
> annoying stuff when running buildroot from a text console. And in fact,
> the same is true of the colouring itself, so we don't get these annoying
> escape characters in log files and continuous integration web interfaces.
>
> Agreed.
>
> Best regards,
> Thomas
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-08-20 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 20:46 [Buildroot] [PATCH] infra: display current task as title of the term window Francois Perrad
2013-08-07 6:44 ` Thomas De Schampheleire
2013-08-07 8:15 ` Carsten Schoenert
2013-08-07 8:20 ` Thomas De Schampheleire
2013-08-07 10:56 ` Carsten Schoenert
2013-08-07 11:21 ` Thomas De Schampheleire
2013-08-07 8:45 ` François Perrad
2013-08-07 9:11 ` Thomas De Schampheleire
2013-08-07 14:11 ` Danomi Manchego
2013-08-13 5:36 ` Arnout Vandecappelle
2013-08-18 8:21 ` Thomas De Schampheleire
2013-08-19 16:19 ` Arnout Vandecappelle
2013-08-19 18:49 ` Thomas De Schampheleire
2013-08-20 22:32 ` Arnout Vandecappelle [this message]
2013-08-21 3:27 ` Thomas De Schampheleire
2014-03-15 18:43 ` Thomas De Schampheleire
2013-08-18 13:15 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5213EE6F.7040006@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox