From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/Makefile.in: add a way to don't force jobs in sub-make
Date: Wed, 21 Aug 2013 21:17:08 +0200 [thread overview]
Message-ID: <52151234.2040605@mind.be> (raw)
In-Reply-To: <1374138746-23279-2-git-send-email-fabio.porcedda@gmail.com>
On 18/07/13 11:12, Fabio Porcedda wrote:
> When the "BR2_JLEVEL" variable is empty use "make"
> without the "-j" option.
> To be able to use top-level parallel make we must don't force
> the number of jobs in sub-make.
>
> Example:
> make BR2_JLEVEL= -j8
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
If only because it's a bad idea to start a linux build with
-j<nothing>. I did that while testing the baseline for this patch and was
caught in a swap storm...
Regards,
Arnout
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index a597290..c36ee4c 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -18,7 +18,7 @@ PARALLEL_JOBS:=$(BR2_JLEVEL)
> endif
>
> MAKE1:=$(HOSTMAKE) -j1
> -MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS)
> +MAKE:=$(HOSTMAKE) $(if $(PARALLEL_JOBS),-j$(PARALLEL_JOBS))
>
> # Compute GNU_TARGET_NAME
> GNU_TARGET_NAME=$(ARCH)-buildroot-linux-$(LIBC)$(ABI)
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-08-21 19:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 9:12 [Buildroot] [PATCH v2 0/3] Fix for top-level parallel make part 1 Fabio Porcedda
2013-07-18 9:12 ` [Buildroot] [PATCH v2 1/3] package/Makefile.in: add a way to don't force jobs in sub-make Fabio Porcedda
2013-08-21 19:17 ` Arnout Vandecappelle [this message]
2013-07-18 9:12 ` [Buildroot] [PATCH v2 2/3] package: fix generic extract target for top-level parallel make Fabio Porcedda
2013-08-21 19:24 ` Arnout Vandecappelle
2013-08-22 7:44 ` Fabio Porcedda
2013-08-22 15:59 ` Arnout Vandecappelle
2013-08-23 11:31 ` Fabio Porcedda
2013-08-26 8:29 ` Fabio Porcedda
2013-08-27 6:01 ` Arnout Vandecappelle
2013-08-28 8:26 ` Fabio Porcedda
2013-08-23 7:36 ` Thomas Petazzoni
2013-08-23 8:00 ` Fabio Porcedda
2013-08-23 11:14 ` Thomas Petazzoni
2013-07-18 9:12 ` [Buildroot] [PATCH v2 3/3] package: fix generic patch " Fabio Porcedda
2013-07-18 9:38 ` [Buildroot] [PATCH v2 0/3] Fix for top-level parallel make part 1 Thomas Petazzoni
2013-07-19 15:41 ` Fabio Porcedda
2013-07-27 11:18 ` Thomas Petazzoni
2013-07-30 9:34 ` Fabio Porcedda
2013-07-30 10:01 ` Thomas Petazzoni
2013-07-30 10:16 ` Fabio Porcedda
2013-07-30 11:29 ` Thomas Petazzoni
2013-08-12 16:48 ` Arnout Vandecappelle
2013-08-20 12:14 ` Fabio Porcedda
2013-08-20 17:35 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52151234.2040605@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox