From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openssh: fix tab/spacing in init script
Date: Thu, 22 Aug 2013 18:11:37 +0200 [thread overview]
Message-ID: <52163839.5060204@mind.be> (raw)
In-Reply-To: <CAAXf6LXSo5Z56BO611E1iv5WUzvtzH+0Ocvr6LD3vSanmrLHkw@mail.gmail.com>
On 22/08/13 15:59, Thomas De Schampheleire wrote:
>> >I'd be willing to go through all of them and make them uniform, if
>> >recommended guidelines can be stated with regards to the above variations.
>> >Tabs are tempting only because it's a single character in text files that go
>> >in the target - otherwise, I'm normally in the tabs-are-evil camp, since
>> >thing which start out with tabs tend get modified with spaces over time, and
>> >because editor rendering of tab width can vary. So I'd be willing to go
>> >either way.
> Thanks for checking. Seems there was more variance than I expected.
>
> I'm not sure what to do here. Unless such init scripts have been
> copied from elsewhere (in which making cosmetic changes may be
> undesirable), I'm ok with having them changed according to a given
> guideline.
If it is copied from elsewhere then it probably shouldn't be in
buildroot, but just copied from elsewhere.
> Before trying to establish such a guideline, what does the community
> think about this?
> If there is no consensus in changing, then no need for a guideline.
I guess that's a judgement call for Peter to make.
Note that we also have this kind of whitespace inconsistencies in e.g.
support/scripts.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-08-22 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 1:11 [Buildroot] [PATCH] openssh: fix tab/spacing in init script Danomi Manchego
2013-08-21 3:55 ` Thomas De Schampheleire
[not found] ` <CAAXf6LUO9M-Nghy8ZVMS7L0y2J+=3G6kw1eJKnMUhWOt9wGg4Q@mail.gmail.com>
2013-08-21 13:39 ` Danomi Manchego
2013-08-22 13:59 ` Thomas De Schampheleire
2013-08-22 16:11 ` Arnout Vandecappelle [this message]
2013-08-27 20:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52163839.5060204@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox