From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] getty: Create specific getty config + cleanups
Date: Tue, 27 Aug 2013 14:27:59 +0200 [thread overview]
Message-ID: <521C9B4F.4000300@mind.be> (raw)
In-Reply-To: <CAAXf6LV4mAJ77obaOx_7O9Dk_=a9oFGrW8QcFoAzdAKThAqjLA@mail.gmail.com>
On 08/27/13 12:33, Thomas De Schampheleire wrote:
>> >+TARGET_GENERIC_HOSTNAME = $(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
>> >+TARGET_GENERIC_ISSUE = $(call qstrip,$(BR2_TARGET_GENERIC_ISSUE))
>> >+TARGET_GENERIC_ROOT_PASSWD = $(call qstrip,$(BR2_TARGET_GENERIC_ROOT_PASSWD))
>> >+TARGET_GENERIC_PASSWD_METHOD = $(call qstrip,$(BR2_TARGET_GENERIC_PASSWD_METHOD))
>> >+TARGET_GENERIC_GETTY_PORT = $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT))
>> >+TARGET_GENERIC_GETTY_BAUDRATE = $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE))
>> >+TARGET_GENERIC_GETTY_TERM = $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_TERM))
>> >+TARGET_GENERIC_GETTY_OPTIONS = $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_OPTIONS))
> Although in general = is favored over := in buildroot, I'm now
> wondering if this is the right choice here: variable
> TARGET_GENERIC_GETTY_PORT is used several times in .mk. If = is used,
> the qstrip expansion is done each time, while := will do it once.
Remember that := will expand once, even if it is never used. So using =
is sometimes even more efficient.
> Arnout: isn't this ($(call), $(shell), ...) a case where we should
> rather use := iso = ?
For $(shell), yes (on condition that it is _always_ evaluated). But the
overhead of $(call) isn't very high. These variables are used a couple of
times, but every time it is within a separate sub-shell - the overhead of
starting that sub-shell is way higher than the overhead of running a $(call).
So no, this is not a case where := would be more appropriate. It's not
even a case where := is necessarily faster.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-08-27 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[Buildroot] [PATCH] getty: add the ability to pass options to getty>
2013-08-25 11:13 ` [Buildroot] [PATCH v2 1/2] getty: Create specific getty config + cleanups Assaf Inbal
2013-08-25 11:13 ` [Buildroot] [PATCH v2 2/2] getty: add the ability to pass options to getty Assaf Inbal
2013-08-27 10:34 ` Thomas De Schampheleire
2013-08-27 10:33 ` [Buildroot] [PATCH v2 1/2] getty: Create specific getty config + cleanups Thomas De Schampheleire
2013-08-27 12:27 ` Arnout Vandecappelle [this message]
2013-08-28 4:41 ` Assaf Inbal
2013-08-28 6:36 ` Thomas De Schampheleire
[not found] ` <CADwac6A7kn8sXLiQERrmk4iUbtob8oVqeTMcSYTd8rJW3d9wZg@mail.gmail.com>
2013-09-04 9:31 ` Thomas De Schampheleire
2013-09-06 6:59 ` Assaf Inbal
2013-09-06 8:18 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C9B4F.4000300@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox